Contrib.social

Replace use of whitelist/blacklist in core/misc/autocomplete.js and LinkWidget.php

Open on Drupal.org →
Created on 12 June 2020, over 4 years ago
Updated 4 September 2024, 4 months ago

Problem/Motivation

Lets remove usage of "blacklist" and "whitelist" in core/misc/autocomplete.es6.js and core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php. This is likely to need a deprecated BC layer.

They are:

  • An historic bad labelling of people
  • Provide no context: "what is listed in them"?

Proposed resolution

Convert options.firstCharacterBlacklist to options.firstCharacterDenyList

Remaining tasks

Add deprecations as needed for the javaScript changes
Review

User interface changes

None

API changes

@todo

Data model changes

@todo

Release notes snippet

@todo

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Javascript  →

Last updated 3 days ago

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Comment 4 months ago →
    🇳🇿New Zealand quietone

    Convert to an MR.

  • Merge request !9178convert #4 → (Open) created by quietone
  • Comment 4 months ago →
    🇳🇿New Zealand quietone
  • Pipeline finished with Success
    4 months ago
    Total: 440s
    #251441
  • Pipeline finished with Success
    4 months ago
    Total: 436s
    #267824
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇳🇿New Zealand quietone

    I had a go at adding the deprecation, I don't know if it is correct or not.

  • Status changed to RTBC 4 months ago
  • Comment 4 months ago →
    🇺🇸United States smustgrave

    Applied the MR and searched for whitelist and blacklist and only findings were the deprecations.

    LGTM.

  • Comment 4 months ago →
    🇫🇷France nod_ Lille

    small nitpick on variable name

  • Pipeline finished with Success
    4 months ago
    Total: 157664s
    #271667
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇫🇷France nod_ Lille

    This would need a change record, maybe taking inspiration from https://www.drupal.org/node/3162143 →

  • Comment 4 months ago →
    🇫🇷France nod_ Lille
  • Pipeline finished with Failed
    4 months ago
    Total: 308s
    #273318
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇳🇿New Zealand quietone

    I thought I had added a deprecation notice here. In any event, an attempt at one is added. It must be wrong but I don' t know how to fix it.

  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇺🇸United States smustgrave

    MR appears to have failures now

    CR is straight forward though so removing tag.

  • First commit to issue fork.
  • Pipeline finished with Failed
    about 2 months ago
    Total: 678s
    #317987
  • Pipeline finished with Failed
    about 2 months ago
    Total: 803s
    #318015
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024