Contrib.social

Replacing(?) jQuery UI resizable

Open on Drupal.org →
Created on 5 March 2021, over 3 years ago
Updated 30 September 2023, about 1 year ago

Problem/Motivation

Steps to reproduce

Proposed resolution

I see two different sets of choices that need to be made in order to settle on an approach:

Is it necessary to keep resizable functionality around?

So far, Drupal core's replacements for jQuery UI functionality have provided identical or better functionality, and gone to lengths to support backwards compatibility. Examples: 📌 Add a native dialog element to deprecate the jQuery UI dialog Needs work , 📌 Provide a new library to replace jQuery UI autocomplete Needs work , #3201170: Address jQuery UI position dependency → . In the case of Resizable, however, it's worth discussing if a replacement is needed. Modal dialogs are already non-resizable, and it's unclear how many users are even aware that off-canvas dialogs are resizable.
Skipping pros:Feature may be largely unused. This would eliminate the need for a complex shim and additional code/libraries to maintain.
Skipping cons:It's possible this is an important feature for some users. It would be removing functionality that was previously there.

If we do maintain the functionality, how do we replace it?

  • Find a replacement library and provide a backwards compatible shim, keeping in mind that shimming something like resizable would necessitate a very complex shim
  • Create a custom replacement and provide a backwards compatible shim, also keeping in mind that something like resizable would necessitate a very complex shim
  • Make jQuery UI resizable the only part of the jQuery UI custom fork we keep in Drupal core. This would require 6 jQuery UI assets: "./mouse","../disable-selection","../plugin","../version","../widget"
  • The Drupal 9 jQuery UI dialog shim can use jQuery UI resizable, but it will include a deprecation warning that the ability to resize will not be provided in Drupal 10.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🌱 Plan
Status

Active

Version

11.0 🔥

Component
Javascript  →

Last updated 1 day ago

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
  • Needs product manager review

    It is used to alert the product manager core committer(s) that an issue represents a significant new feature, UI change, or change to the "user experience" of Drupal, and their signoff is needed. If an issue significantly affects the usability of Drupal, use Needs usability review instead (see the governance policy draft for more information).

  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇷🇸Serbia finnsky

    Hi everybody!
    I added a proof of concept demonstrating https://interactjs.io/ for resizing.
    We can add some arbitrary internal library for resize (and not only) that will work for attributes like “data-resize-element” or “data-resize-element=left”.
    Before the patch, the resize does not look very good in offcanvas:

    After the patch:

    This library also supports drag and drop and much more. There also seems to be modularity. Could be a good alternative to the current resize implementation and could be an independent part to make it easier to redesign dialog boxes. MR is pretty rough but it definitely shows the benefits of this library.

    Please review

  • Comment about 1 year ago →
    🇷🇸Serbia finnsky

    For test enable Layout Builder module and enable it for article. Also Workspaces module.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    Build Successful
  • @finnsky opened merge request.
  • Comment about 1 year ago →
    🇷🇸Serbia finnsky
  • Status changed to Needs work about 2 months ago
  • Comment about 2 months ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

  • Comment about 1 month ago →
    needs-review-queue-bot

    False positive

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024