- 🇨🇦Canada othermachines Edmonton, Alberta
Thanks! My core version is 10.2.7.
I should have clarified that the patch in #12 contains the fix for me as it simply adds
:array
to the end of the signature. Please see the error message which is about compatibility unlike that in the OP which is about access level. - 🇨🇦Canada othermachines Edmonton, Alberta
Like #12 I also needed to apply a patch which adds
: array
. It resolves a 500 error when creating a custom block.This is with the core fix from 📌 Revisit the redirect to 'add block' form in the 'add block content' form Fixed .
Error is:
PHP Fatal error: Declaration of Drupal\panels_ipe\Form\PanelsIPEBlockContentForm::actions(array $form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\block_content\BlockContentForm::actions(array $form, Drupal\Core\Form\FormStateInterface $form_state): array in D:\--\web\modules\contrib\panels\panels_ipe\src\Form\PanelsIPEBlockContentForm.php on line 18
Perhaps a new issue should be opened...
- 🇬🇧United Kingdom scott_euser
Thanks for confirming! New release made 4.0.0-beta5
- 🇨🇦Canada camilocodes
Thank you very much. I can confirm that, at least for now, the issue is fixed in 4.x-dev.
- 🇬🇧United Kingdom scott_euser
In any case, does not harm having higher z-index so committed to dev
- 🇬🇧United Kingdom scott_euser
If you could confirm this also sorts the issue for you, I'll make a new release, but solves for me in my testing.
-
scott_euser →
committed 467e2840 on 4.0.x
Issue #3463159 by scott_euser, camilocodes: Unable to insert/edit links...
-
scott_euser →
committed 467e2840 on 4.0.x
- @scott_euser opened merge request.
- 🇬🇧United Kingdom scott_euser
Thanks for thoroughly checking. Looks like the issue in Core has changed the needed z-index, so the link balloon (the mini-CKE dialog) is now below the modal. See 🐛 CKEditor 5 balloons invisible when CKEditor 5 is used inside a modal Needs work .
We can update the temp solution here so it doesn't catch people out, but ultimately if that issue remains a moving target, this could occur again until the core itself itself is fixed (ie, its not an issue with this module).
- 🇨🇦Canada camilocodes
Update:
I can now verify that this is an issue on a clean install of D10, CKE5, Footnotes 4.0.0-beta4. You can easily verify the results by following these steps:
- Navigate to simplytest.me
- Type in and select "footnotres" in the "Evaluate Drupal projects" input box. Make sure the version is 4.0.0-beta4
- Click "Launch Sanbdbox"
- Log into the sandbox as admin/admin
- Navigate to content > Add content > Basic page
- Add a title
- For the body text, select the Footnote text format.
- Write some text, select it, and then use the link widget to make it a link.
- RESULT: The link dialog opens and the link can be created without issue.
- Navigate to Configuration > Text formats and editors
- Click the Configure button for the Full HTML format.
- Drag the Footnotes widget to the toolbar and click Save configuration.
- Create another basic page.
- Add a title.
- For the body, select the Full HTML text format.
- Write some text, select it, and then use the link widget to make it a link.
- RESULT: The link dialog isn't displayed, a CKEditor selection wrapper is added to the selected text HTML, but nothing else happens. No errors are send to the borwser console or the Drupal logs. This failure in functionality is identical to what we are observing in our production site. - 🇨🇦Canada camilocodes
I can check with a fresh install. Can you please confirm that you are using this feature in a production Drupal 10, CKEditor5 environment under footnotes version 4.0.0-beta4?
- 🇬🇧United Kingdom scott_euser
Can you reproduce it in a clean install please to narrow down custom code or other modules causing issues for you? We (and it seems a couple hundred other sites) are using this in production fine.
Can you also check if the text format you are adding it into also supports links? I suppose one possibility is that you have limit allowed html on and have links not allowed... But it's just a guess as links work fine for all the sites I used this on myself.
- 🇷🇸Serbia finnsky
I lile this new approach more than previous.
Now i've used `span 2 or 3`
so 25 + 25 + 50 has same middle gap as 50 + 25 + 50
etc.Please review!
- @finnsky opened merge request.