Account created on 19 January 2022, over 3 years ago
  • Strong Junior Drupal Developer at DevBranch 
#

Merge Requests

More

Recent comments

🇺🇦Ukraine Foxy-vikvik

Thanks for your work. I forgot to say that textfields_container is incorrect key. We need to update it too


  public function textfieldsCallback($form, FormStateInterface $form_state) {
    return $form[’textfields_container'];
}
🇺🇦Ukraine Foxy-vikvik

Hello,

This behavior is intentional. The forced integration of the caption field into all image field widgets was removed in version 4, as it could interfere with other widget implementations. Now, the module only integrates with the core image widget.

Therefore, this should be a Feature Request.

🇺🇦Ukraine Foxy-vikvik

I can confirm — it works well on Drupal 10.2.

🇺🇦Ukraine Foxy-vikvik

Patched based on the changes from the merge request and works fine with Drupal 10.

🇺🇦Ukraine Foxy-vikvik

foxy-vikvik changed the visibility of the branch 3195407-add-support-for to hidden.

🇺🇦Ukraine Foxy-vikvik

I have added text for a11y purposes on current patch. But didn't style it (We had a tailwind, it has such a class).

🇺🇦Ukraine Foxy-vikvik

I have added changes to the js/views/AddToCart.js file on the merge request.

🇺🇦Ukraine Foxy-vikvik

@nathaniel I suggest creating a patch based on the current merge request 📌 Rewrite module to use default field storage Active and switching to the default field storage for the caption field. I’m also planning to add a Kernel test and prepare a new release of the module with these improvements.

🇺🇦Ukraine Foxy-vikvik

SCD components not working after applying the patch

Twig\Error\RuntimeError: The "Drupal\Core\Template\TwigExtension" extension is not enabled in "theme:footer". in Twig\ExtensionSet->getExtension() (line 80 of /var/www/html/vendor/twig/twig/src/ExtensionSet.php).
🇺🇦Ukraine Foxy-vikvik

I have hidden the patch, as it does not provide an optimal solution.

As per the documentation, ARIA: tooltip role, this approach is not recommended.

The accessible name of a tooltip can come from the contents. While, in theory, they could come from an aria-label or aria-labelledby, in most cases, using ARIA properties to provide a tooltip with an accessible name is not recommended.

🇺🇦Ukraine Foxy-vikvik

@klausi
I initially planned to rewrite the module for version 3, including a hook update to migrate from the current values to the new ones. However, upon checking, I found that 72 sites are using the 3.0.x version. You are correct that upgrading to the latest version, which requires Drupal 10.3, could pose risks for those sites. As a result, I’ve reconsidered my approach and decided to roll back the branch. I will now create an alpha release for the 4.x branch instead.

🇺🇦Ukraine Foxy-vikvik

Confirmed for Drupal 10.3 and Webform 6.3.0-beta-1 works fine and the screen reader can read the tooltip content
Patch from the merge request:

🇺🇦Ukraine Foxy-vikvik

@dieterholvoet It was a mistake. I found an issue and changed it. This merge request is still a work in progress. So it will be formatted text. I will change it when I have time.

🇺🇦Ukraine Foxy-vikvik

foxy-vikvik changed the visibility of the branch 3.0.x to hidden.

🇺🇦Ukraine Foxy-vikvik

Confirmed that all pipelines have been resolved and successfully merged the merge request.

🇺🇦Ukraine Foxy-vikvik

It was fixed (commented part of the code on 2.0.x branch) It will be removed soon

🇺🇦Ukraine Foxy-vikvik

I have merged the latest changes and will work on rewriting some parts of the module using Field API. We will have a v3

🇺🇦Ukraine Foxy-vikvik

I have added a checkbox. When it checks it will show a hidden textfield where we will add the URL for testing purposes.

🇺🇦Ukraine Foxy-vikvik

Also updated comments into the functions in the UrlInspectionOperationsManager class

🇺🇦Ukraine Foxy-vikvik

I rewrote a little bit of information from ReadMe.txt and added links into Readme.md

🇺🇦Ukraine Foxy-vikvik

Added general information how to set up the module

🇺🇦Ukraine Foxy-vikvik

foxy-vikvik made their first commit to this issue’s fork.

🇺🇦Ukraine Foxy-vikvik

Related to current issue - https://www.drupal.org/project/calendar_view/issues/3405794 🐛 All-day dates start early Fixed
I reverted the changed in the merge request because it is not working if we have on standard timezone in the site and not correct data range.

🇺🇦Ukraine Foxy-vikvik

It happens because it renders dates in different time zones
I have UTC for one field and (America/Toronto) fro another

🇺🇦Ukraine Foxy-vikvik

Patch from this this issue 🐛 Facets breaks all AJAX views that uses pagers even without facets Active related to the Factets fixed the issue with pagination

🇺🇦Ukraine Foxy-vikvik

I am working on a project where we use Gin + Paragraphs, and your code does not work for me.

Production build 0.71.5 2024