Account created on 19 January 2022, over 2 years ago
#

Merge Requests

More

Recent comments

🇺🇦Ukraine Foxy-vikvik

Duplicate this https://www.drupal.org/project/custom_search/issues/3040533 Only require input for any-value if taxonomy vocabulary is enabled Needs review

🇺🇦Ukraine Foxy-vikvik

Hello. @smustgrave Could you please read the summary maybe It will answer your question.

I suggest removing direct support for this library because:
1. This library is deprecated.
2. The module should not care about the support of all libraries in this regard. The module already has a way to disable the automatic submission of input fields using the [data-bef-auto-submit-exclude] attribute.

🇺🇦Ukraine Foxy-vikvik

Validate condition for the form Validate method was added.

🇺🇦Ukraine Foxy-vikvik

.gitlab-ci.yml file was added into the root repo

🇺🇦Ukraine Foxy-vikvik

The style link issue was fixed in the last merge request.

🇺🇦Ukraine Foxy-vikvik

Foxy-vikvik made their first commit to this issue’s fork.

🇺🇦Ukraine Foxy-vikvik

It is working in native views on Drupal 10

🇺🇦Ukraine Foxy-vikvik

I know it looks like an exception but It may happen

🇺🇦Ukraine Foxy-vikvik

Steps to reproduce:
- In content type we had one comment type - with a "text plain" field
- Some comment entities were created
- We need to change "text plain" to "text field formatted - need CKEditor" that's why we created a new comment type (prev we use in other content types)
- I have removed comment field with plain text and created with formatted
and in the /admin/content/comment found an issue

The website encountered an unexpected error. Please try again later.
Error: Call to a member function getSetting() on null in Drupal\comment_delete\CommentDeleteManager->getConfig() (line 121 of modules/contrib/comment_delete/src/CommentDeleteManager.php).
🇺🇦Ukraine Foxy-vikvik

In Drupal 9.5 and PHP 8.1 work correctly

🇺🇦Ukraine Foxy-vikvik

Steps to reproduce:
1) Enabled the module
2) Enabled admin theme for layout builder on /admin/config/content/lbat
3) Go to any page with Layout Builder and you will see (picture below)
if enabled

and without

🇺🇦Ukraine Foxy-vikvik

#16 patch didn't work for Drupal 10
but another #176 from refs # 3059955 - It is possible to overflow the number of items allowed in Media Library 🐛 It is possible to overflow the number of items allowed in Media Library Fixed work fine

🇺🇦Ukraine Foxy-vikvik

In my case In node with paragraph - if I press the Collapse button - MaxLength message will disappear

🇺🇦Ukraine Foxy-vikvik

Re-used #5 patch.
Works fine with php 8.0.27 Drupal v 9.5.10

🇺🇦Ukraine Foxy-vikvik

Did you use the lenient for installing custom_breadcrumbs module on Drupal 10?
On 10.1.0 it is working well without any issues.

🇺🇦Ukraine Foxy-vikvik

On Drupal 10, PHP 8.1 working well
Patch from MR

🇺🇦Ukraine Foxy-vikvik

Result from the Upgrade status

Visual Website Optimizer,  8.x-1.1

FILE: modules/contrib/visual_website_optimizer/visual_website_optimizer.module

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix now        273  Call to deprecated function module_load_include().          
                    Deprecated in drupal:9.4.0 and is removed from              
                    drupal:11.0.0. Use                                          
                    Drupal::moduleHandler()->loadInclude($module, $type, $name =
                    NULL). Note that including code from uninstalled extensions 
                    is no longer supported.                                     
--------------------------------------------------------------------------------
Fix now        278  Call to deprecated function module_load_include().          
                    Deprecated in drupal:9.4.0 and is removed from              
                    drupal:11.0.0. Use                                          
                    Drupal::moduleHandler()->loadInclude($module, $type, $name =
                    NULL). Note that including code from uninstalled extensions 
                    is no longer supported.                                     
--------------------------------------------------------------------------------
Fix now        283  Call to deprecated function module_load_include().          
                    Deprecated in drupal:9.4.0 and is removed from              
                    drupal:11.0.0. Use                                          
                    Drupal::moduleHandler()->loadInclude($module, $type, $name =
                    NULL). Note that including code from uninstalled extensions 
                    is no longer supported.                                     
--------------------------------------------------------------------------------

FILE: modules/contrib/visual_website_optimizer/visual_website_optimizer.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8.8.0 || ^9 is not      
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: modules/contrib/visual_website_optimizer/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.   
--------------------------------------------------------------------------------
🇺🇦Ukraine Foxy-vikvik
Alter Entity Autocomplete,  8.x-1.0
Scanned on Tue 11/07/2023 - 09:52

FILE:
modules/contrib/alter_entity_autocomplete/src/AlterEntityAutocomplete/AlterEntit
yAutocompleteMatcher.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 48   Relying on entity queries to check access by default is     
                    deprecated in drupal:9.2.0 and an error will be thrown from 
                    drupal:10.0.0. Call                                         
                    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
                    TRUE or FALSE to specify whether access should be checked.  
--------------------------------------------------------------------------------

FILE:
modules/contrib/alter_entity_autocomplete/alter_entity_autocomplete.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Issues from Upgrade status

🇺🇦Ukraine Foxy-vikvik

I'm having trouble with the previous patch. Patch with the latest changes for the 1.0.1 branch
I have added Null value in the BreadcrumbBuilder__construct()

🇺🇦Ukraine Foxy-vikvik
The website encountered an unexpected error. Please try again later.
ArgumentCountError: Too few arguments to function Drupal\custom_breadcrumbs\BreadcrumbBuilder::__construct(), 9 passed in /var/www/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 10 expected in Drupal\custom_breadcrumbs\BreadcrumbBuilder->__construct() (line 137 of modules/contrib/custom_breadcrumbs/src/BreadcrumbBuilder.php).
Drupal\custom_breadcrumbs\BreadcrumbBuilder->__construct(Object, Object, Object, Object, Object, Object, Object, Object, Object) (Line: 259)
Drupal\Component\DependencyInjection\Container->createService(Array, 'beneva.breadcrumb') (Line: 177)

Had that issue related to fileUrlGenerator
Drupal 9.5 and PHP 8.1

🇺🇦Ukraine Foxy-vikvik

Compatible with Drupal 9.5 and PHP 8.1

🇺🇦Ukraine Foxy-vikvik

Fixed issue related to hint. ConfigFactory was changed inside the TaxonomyViewsIntegratorSettingsForm Class constructor. Added some coding standard fixes.

🇺🇦Ukraine Foxy-vikvik

Foxy-vikvik made their first commit to this issue’s fork.

🇺🇦Ukraine Foxy-vikvik

#64 patch working well on Drupal 10 (PHP 8.1)

🇺🇦Ukraine Foxy-vikvik

#13 working for me. I don't know why(looks good) but #3 didn't work.

🇺🇦Ukraine Foxy-vikvik

@mark_fullmer still working on it. The structure was changed.
If you have any suggestion Could you please add it here.

🇺🇦Ukraine Foxy-vikvik

The same as the #6 patch - only changed deprecated function in requestStack to getMainRequest

🇺🇦Ukraine Foxy-vikvik

Patch from the latest changes on MR

🇺🇦Ukraine Foxy-vikvik

Patch #6 isn't working on Drupal 10

🇺🇦Ukraine Foxy-vikvik

I tested it on Drupal 10 - it is workes well
superfish-d10-compatibility-15053339-9.patch

🇺🇦Ukraine Foxy-vikvik

As for me #7 patch is not working and it was not applied.

Production build 0.69.0 2024