- Issue created by @tim.tripp
- Merge request !8338Issue #3453320: Renames `--ck-z-modal` to `--ck-z-panel` → (Closed) created by Unnamed author
- Status changed to Needs review
6 months ago 9:49pm 7 June 2024 - Status changed to Needs work
6 months ago 2:46pm 13 June 2024 - 🇺🇸United States smustgrave
Seems straight forward. but can MR be updated for 11.x please.
- Merge request !8415Issue #3453320: Renames `--ck-z-modal` to `--ck-z-panel` → (Open) created by Unnamed author
- Status changed to Needs review
6 months ago 2:57pm 14 June 2024 - Status changed to RTBC
6 months ago 4:22pm 14 June 2024 -
alexpott →
committed 16267872 on 10.3.x
Issue #3453320 by timurtripp: [10.3 regression] CKEditor 5 renamed CSS...
-
alexpott →
committed 16267872 on 10.3.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 703830324b to 11.x and c6702c5ed9 to 11.0.x and b4ffe7ef4b to 10.4.x and 162678726c to 10.3.x. Thanks!
It might be great if there was a test somewhere for this. I didn't make it a requirement for merging because of the regression but given we have CSS to address the issue and we integrate ckeditor and jQuery perhaps a test is worth it.
-
alexpott →
committed b4ffe7ef on 10.4.x
Issue #3453320 by timurtripp: [10.3 regression] CKEditor 5 renamed CSS...
-
alexpott →
committed b4ffe7ef on 10.4.x
-
alexpott →
committed c6702c5e on 11.0.x
Issue #3453320 by timurtripp: [10.3 regression] CKEditor 5 renamed CSS...
-
alexpott →
committed c6702c5e on 11.0.x
- Status changed to Fixed
6 months ago 9:49am 15 June 2024 -
alexpott →
committed 70383032 on 11.x
Issue #3453320 by timurtripp: [10.3 regression] CKEditor 5 renamed CSS...
-
alexpott →
committed 70383032 on 11.x
- Status changed to Needs work
5 months ago 11:13am 27 June 2024 .ui-dialog ~ .ck-body-wrapper
This does not solve the problem if an instance of CKEditor was already placed on the page and after that the dialog was opened. Then.ck-body-wrapperwill be before.ui-dialogI suggest overriding the
--ck-z-panelvariable without additional conditions- Status changed to Fixed
5 months ago 10:49pm 30 June 2024 Work on the issue I mentioned in #19 continues here https://www.drupal.org/project/drupal/issues/3328425 🐛 CKEditor 5 balloons invisible when CKEditor 5 is used inside a modal Needs work so I return the status to "Fixed" since the original issue has been fixed, the variable has been renamed.
Automatically closed - issue fixed for 2 weeks with no activity.