- Issue created by @kksandr
- Status changed to Needs review
over 1 year ago 8:55am 30 August 2023 - First commit to issue fork.
-
smustgrave →
committed 8a91e6d6 on 6.0.x authored by
kksandr →
Issue #3384228: Remove "chosen-js" support
-
smustgrave →
committed 8a91e6d6 on 6.0.x authored by
kksandr →
- Status changed to Fixed
9 months ago 11:41pm 10 April 2024 -
smustgrave →
committed b18379ea on 6.0.x
Revert "Issue #3384228: Remove "chosen-js" support"
-
smustgrave →
committed b18379ea on 6.0.x
- Status changed to Postponed: needs info
9 months ago 11:42pm 10 April 2024 - 🇺🇸United States smustgrave
Merged too eagerly but reverted.
Can it be explained why this code needs to be removed?
- Status changed to Needs review
9 months ago 7:14am 11 April 2024 - 🇺🇦Ukraine Foxy-vikvik
Hello. @smustgrave Could you please read the summary maybe It will answer your question.
I suggest removing direct support for this library because:
1. This library is deprecated.
2. The module should not care about the support of all libraries in this regard. The module already has a way to disable the automatic submission of input fields using the [data-bef-auto-submit-exclude] attribute. Can it be explained why this code needs to be removed?
The
if (... || $target.attr('autocomplete') == 'off')
condition was added to support "chosen-js" here #3211296 → . This broke jQuery Datepicker as it hasautocomplete="off"
and this was solved by adding another conditionif (... || ($target.attr('autocomplete') == ' off') && !$target.hasClass('bef-datepicker'))
here #3224329 → .Therefore, removing support for "chosen-js" allows you to remove these additional conditions. I cannot write a more detailed explanation.
kksandr → changed the visibility of the branch 3384228-remove-chosen-js-support to hidden.
kksandr → changed the visibility of the branch 3440045-add-gitlab-file to hidden.
- Merge request !60Revert "Revert "Issue #3384228: Remove "chosen-js" support"" → (Merged) created by Unnamed author
-
smustgrave →
committed 5fb41601 on 6.0.x authored by
kksandr →
Revert "Revert "Issue #3384228: Remove "chosen-js" support""
-
smustgrave →
committed 5fb41601 on 6.0.x authored by
kksandr →
- Status changed to Fixed
9 months ago 1:04pm 11 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.