- First commit to issue fork.
- Merge request !21#3184748 fix(paragraphs): Fix issue when saving caption the first time on a paragraph β (Merged) created by klausi
- π¦πΉAustria klausi π¦πΉ Vienna
Created a merge request with a different approach for the 3.x version. Please review!
Patch file attached for composer.
- πΊπ¦Ukraine Foxy-vikvik
@klausi I changed the branch to 2.0.x because all these changes will be removed on the 3.0.x
I am working on it
https://git.drupalcode.org/project/image_field_caption/-/merge_requests/... - π¦πΉAustria klausi π¦πΉ Vienna
Aha, interesting!
But you cannot make drastic changes on 3.x as that has a stable release already. So you have to publish the rewrite under version 4.x, right?
- πΊπ¦Ukraine Foxy-vikvik
@klausi
I initially planned to rewrite the module for version 3, including a hook update to migrate from the current values to the new ones. However, upon checking, I found that 72 sites are using the 3.0.x version. You are correct that upgrading to the latest version, which requires Drupal 10.3, could pose risks for those sites. As a result, Iβve reconsidered my approach and decided to roll back the branch. I will now create an alpha release for the 4.x branch instead. I confirm that the handling of the absence of
$value['image_field_caption']['value']
is correctly implemented here, and it resolves the issue of the value disappearing during repeated programmatic entity saves (not through forms).I am also redirecting this MR to the 2.0.x branch, as a completely new implementation of the module is planned for the 3.0.x branch.
-
foxy-vikvik β
committed e08fc206 on 2.0.x authored by
klausi β
#3184748 fix(paragraphs): Fix issue when saving caption the first time...
-
foxy-vikvik β
committed e08fc206 on 2.0.x authored by
klausi β
Automatically closed - issue fixed for 2 weeks with no activity.