🇮🇳India @jitendra verma

I would like to take over the maintenance of this module as I need it for an ongoing project. I have previously received security coverage opt-in permission. Please add me as a maintainer.

Code has been merged and reviewed.

Patch and code reviewed it resolved the Issue, Thanks aakansha tyagi.

waiting from a long time , Please review

Jitendra verma → created an issue.

Jitendra verma → created an issue.

@cilefen Thanks for your reply.
As in the contact module used the implode method, when fresh from load it gives an array, but when form rebuilds it gets data from the direct field which is strig that why my Ajax call was broken, if we can add there a check for array it will resolve Issue .

if there is any other solution that I can use to solve my problem, Please help

Jitendra verma → created an issue.

Thanks @apaderno, I created a separate issue please have a look https://www.drupal.org/project/adminer/issues/3450524 💬 Offering to maintain Adminer Active .

Jitendra verma → created an issue.

Hi @apaderno
I would like to update this module. Could you please add me as a maintainer?

Sure @astonvictor, Please update your code , I mentioned in the Issue thread.and closing this thread.

Jitendra verma → made their first commit to this issue’s fork.

Jitendra verma → created an issue.

Jitendra verma → created an issue.

Hi there,

I'd like to work on the Drupal 8,9,10 version to create a stable release. So, I want to propose to add me as a co-maintainer.

@BramDriesen sure i will merge request move it in to separate issue,

As i shown interest in become project maintainer before 28 days , and i asked alll maintainers of this project but they don't have permissions to add me as maintainer , Please Help

I fixed the current Issue and cread MR , Please add me as Maintaner , so i can update module reguallarly.

I want to update this module , Please add me as maintainer.

Jitendra verma → created an issue.

Hi
I am interested in maintaining this module.

Jitendra verma → created an issue.

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

Since the project is being used for this application, for the time this application is open, only the user who created the application can commit code.

Please fix PHPCS issues
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/taxonomy_scheduler

FILE: /app/web/modules/contrib/taxonomy_scheduler/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
52 | WARNING | Line exceeds 80 characters; contains 93 characters
59 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------

FILE: ...cheduler/src/EventSubscriber/TaxonomySchedulerCronSubscriber.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
16 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...duler/src/EventSubscriber/TaxonomySchedulerPresaveSubscriber.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
16 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: .../taxonomy_scheduler/src/Exception/TaxonomySchedulerException.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
7 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...pp/web/modules/contrib/taxonomy_scheduler/src/Form/AdminForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
17 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...taxonomy_scheduler/src/Service/TaxonomySchedulerFieldManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
16 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: .../taxonomy_scheduler/src/ValueObject/TaxonomyFieldStorageItem.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...axonomy_scheduler/src/ValueObject/TaxonomySchedulerQueueItem.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...contrib/taxonomy_scheduler/tests/src/Kernel/FieldStorageTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
13 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...xonomy_scheduler/tests/src/Unit/TaxonomyFieldStorageItemTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

Please change the title of issue in this format:
[latest branch] Module name

So that reviewers can check your code.

Thanks

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

Since the project is being used for this application, for the time this application is open, only the user who created the application can commit code.

@apaderno
All the code review comments have been addressed and committed into the branch - 2.0.x . Please review.

Git repo URL - https://git.drupalcode.org/project/social_feeds_block/-/tree/2.0.x
Branch - 2.0.x

Thank you for the feedback.

All the code review comments have been addressed and committed into the branch - 2.0.x . Please validate the same and let me know please if there is any observation.

Git repo URL - https://git.drupalcode.org/project/social_feeds_block/-/tree/2.0.x
Branch - 2.0.x

Jitendra verma → created an issue.

Hi Apaderno,

I crated a sperate post for another Module, Please review https://www.drupal.org/project/projectapplications/issues/3336321 →

Jitendra verma → created an issue.

Drupal 9 version Released https://www.drupal.org/project/social_feeds_block/releases/8.x-1.0-alpha3 →

Hi Apaderno,

Thanks , Yes i am working on another module aswell , I will share that module with you soon.

Hi vishal.kadam & jitesh_1,

Thanks for review,As suggested I have Replace README.txt with README.md and fixed PHPCS Issues https://git.drupalcode.org/project/contact_mail_formatter/-/commit/fd6af...

Jitendra verma → created an issue. See original summary → .