[1.0.x] Contact Mail Formatter

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Remember to change the status, since Active means the project is not yet ready for review. Needs review is the status used when the project is ready for review.

1. It seems you have missed working on the coding standards. You can use the PHPCS tool for checking and resolving issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml contact_mail_formatter/

FILE: contact_mail_formatter/README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
25 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

2. Replace README.txt with README.md
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/documenting-your-project/readmemd-template →

3. Add hook help

4. add composer.json (optional) but good to have. See here https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file#s-define-your-project-as-a-php-package →

Hello @vishal.kadam
Please see comment #2. Please remove this line "Remember to change the status..." since the application status already Needs review.

@jitesh_1 Updated comment #2.

Hi vishal.kadam & jitesh_1,

Thanks for review,As suggested I have Replace README.txt with README.md and fixed PHPCS Issues https://git.drupalcode.org/project/contact_mail_formatter/-/commit/fd6af...

Hello @Jitendra verma
You don't add help hook and although composer.json is optional, I advise you to include it.

@Jitendra verma
I have reviewed the README.md file. It is missing a few required sections.

Update the README.md file as per the documentation → .

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.

Have you made any other contributions that we could instead review?

Hi Apaderno,

Thanks , Yes i am working on another module aswell , I will share that module with you soon.

Hi Apaderno,

I crated a sperate post for another Module, Please review https://www.drupal.org/project/projectapplications/issues/3336321 →