Annotation sidebar settings is not working from a second editor. If field is under tab

Created on 9 February 2024, 4 months ago
Updated 4 March 2024, 3 months ago

Problem/Motivation

CKEditor 5 has a config setting that should determine where the annotation sidebar appears.
It is set to β€œUse inline balloons”, but if text is under a tab group, from second editor it is set to sidebar.

Steps to reproduce

1. Configure Collaboration to be in line.
2. In a Content Type, add 2 field using text area and ckeditor5 with track changes.
3. Change form display to each field be in a different tab, like this:

4. The first tab is OK:

5. BUG: The Second one is using sitebar:

πŸ› Bug report
Status

RTBC

Version

1.2

Component

Plugin: Track Changes

Created by

πŸ‡§πŸ‡·Brazil jkamizato

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jkamizato
  • πŸ‡΅πŸ‡±Poland salmonek

    Hi @jkamizato
    Thank you for bringing this issue to our attention. We'll check the issue soon and notify here once we have a solution.
    I have a question - are you positive that you're using version 1.2.5? In this release we introduced an update to the editor wrappers structure. Toolbar should actually now span over whole editor element (editing area and sidebar). I wonder if your screen was made with older version or is it another bug raleted to tabs.

  • πŸ‡΅πŸ‡±Poland salmonek

    @jakmizato

    We had actually worked on fieldgroup tabs support before. However we only considered auto sidebar mode (based on viewport width).
    For now I simply added handling of fixed sidebar modes within tabs.
    I think we may need to change this to monitor editor visibility in general and apply proper methods once editor becomes visible for user (as this is potential issue for modal windows and custom made tabs which contains editor with sidebar).

    As for now I'm attaching a patch which adds support for fixed mode sidebars in fieldgroup tabs which should work for your site.

  • πŸ‡§πŸ‡·Brazil jkamizato

    Thanks @salmonek! Patch in #5 fixed the issue.

  • Status changed to RTBC 4 months ago
  • πŸ‡΅πŸ‡±Poland salmonek

    @jkamizato

    We have released 1.2.6 with update which should work for all cases where editor is initially hidden (not limited to field group module).
    The #5 patch isn't compatible nor required in 1.2.6

Production build 0.69.0 2024