Account created on 20 October 2012, over 12 years ago
  • Developer at DexaΒ 
#

Merge Requests

Recent comments

πŸ‡§πŸ‡·Brazil jkamizato

@imclean, I think I solved it.

Here the composer:

Add the repository for each fork (seven and adminimal)

    "repositories": {
        "drupal/seven": {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/seven-3434485.git"
        },
        "drupal/devel_entity_updates": {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/devel_entity_updates-3454902.git"
        },

Then add this in require:

"drupal/seven": "dev-3434485-d11-compatibility as 1.0.99",
"drupal/adminimal_theme": "dev-3460890-drupal-11-compatability",

Then run composer update

Hope it works for you.

πŸ‡§πŸ‡·Brazil jkamizato

@imclean

Got it. You are right. I think the only thing we can do is wait for Seven to be released to D11. But your approach is quite good

πŸ‡§πŸ‡·Brazil jkamizato

jkamizato β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡·Brazil jkamizato

jkamizato β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡·Brazil jkamizato

@imclean

I'm preparing the project to upgrate to D10, which mean, its not D11 yet. So, I upgrade Seven using patch

"patches": {
            "drupal/seven": {
                "Upgrade to Drupal 11": "https://git.drupalcode.org/project/seven/-/merge_requests/14.diff"
            },

Then added the fork to repository:

    "repositories": {
          "drupal/adminimal_theme": {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/adminimal_theme-3460890.git"
        },

In "require" section I configured this way:

"drupal/adminimal_admin_toolbar": "2.0.x-dev@dev",
"drupal/seven": "~1.0",

I think you can apply patch to adminimal_admin_toolbar as well and changing repository is not necessary.

Hope I could help you a bit.

πŸ‡§πŸ‡·Brazil jkamizato

jkamizato β†’ created an issue.

πŸ‡§πŸ‡·Brazil jkamizato

I've created an issue in Masterminds/HTML5, asking them to upcast the function `fwrite` , then it fixes the error:

https://github.com/Masterminds/html5-php/issues/254

However, the problem is that this plugin is dependent on Drupal core. I am not sure if it's a core issue or $dom->nodeValue null has to be fixed here.

πŸ‡§πŸ‡·Brazil jkamizato

The phpunit test was fixed and I'm attaching the patch.

πŸ‡§πŸ‡·Brazil jkamizato

I know it needs to fix phpunit issue, but here the latest patch version with phpstan and phpcs fixes

πŸ‡§πŸ‡·Brazil jkamizato

I've created a Merge Request and the patch. Also changed to "Needs Review"

πŸ‡§πŸ‡·Brazil jkamizato

Sorry, wrong patch file. I'm updating the correct file.

πŸ‡§πŸ‡·Brazil jkamizato

Hi @solideogloria, thanks for your advice.

I've recreated this patch using key module dependecy ( https://www.drupal.org/project/key β†’ )

Now, admin user can create a new key entry (user/pass) and reference it in linkchecker configuration.

πŸ‡§πŸ‡·Brazil jkamizato

Hi everyone,

I've created simplest approach, skipping new fields, and configuration. It's passing basic authorization inline, like "login:pass@host.com" in Base Path field.

πŸ‡§πŸ‡·Brazil jkamizato

Hey guys, this works for me and I've created a patch file while new version is not released.

πŸ‡§πŸ‡·Brazil jkamizato

jkamizato β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡·Brazil jkamizato

I've opened a bug in Ckeditor Premium Feture module as well, in case its their issue: https://www.drupal.org/project/ckeditor5_premium_features/issues/3373997 πŸ› When Track Changes is on, Link style module does't work Fixed

πŸ‡§πŸ‡·Brazil jkamizato

Replace ckeditor5_font to  https://www.drupal.org/project/ckeditor_font β†’ , disable editor_advanced_link if you are using and disable Js aggregation.

I'll check if there is a way to disable aggregation only for ckeditor.

πŸ‡§πŸ‡·Brazil jkamizato

Guys, I've created a new branch 3350254-ckeditor-5-36-2 and I've applied manually the patch #23. I'm uploading the new patch and I've updated the code.

πŸ‡§πŸ‡·Brazil jkamizato

I've moved to "need to work" because MR and patches can't be applied.

πŸ‡§πŸ‡·Brazil jkamizato

Tested, good job @icurk !!!

I've changed to priority major, because without this patch Drupal 10 broke.

πŸ‡§πŸ‡·Brazil jkamizato

jkamizato β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡·Brazil jkamizato

In case someone need the patch file

πŸ‡§πŸ‡·Brazil jkamizato

Hey team, I've pushed a update for Drupal 10. Hope its all ok. Thanks!!!

πŸ‡§πŸ‡·Brazil jkamizato

jkamizato β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡·Brazil jkamizato

jkamizato β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡·Brazil jkamizato

jkamizato β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡·Brazil jkamizato

I've change the approach. It was easier to user select option list instead of popup.

Production build 0.71.5 2024