- Issue created by @icurk
- Status changed to Needs review
over 1 year ago 10:00am 13 March 2023 - ๐ช๐ธSpain alvarodemendoza
This is working all right. Moving to RTBC.
- Status changed to RTBC
over 1 year ago 11:17am 13 March 2023 - ๐ง๐ทBrazil jkamizato
Tested, good job @icurk !!!
I've changed to priority major, because without this patch Drupal 10 broke.
- ๐ง๐ทBrazil adrianopulz Florianรณpolis
It worked fine on Drupal 10 and fixed the problem. Great work @icurk!
- ๐ฉ๐ชGermany sascha_meissner Planet earth
Tested the patch, itยดs working fine :-)
- ๐บ๐ธUnited States SamLerner
This worked for me too!
Raising this to Critical because as jkamizato said, without this patch, you can't get this module working at all in D10. And we're only 2 months away from D9 being EOL.
- Status changed to Needs review
about 1 year ago 3:37pm 18 September 2023 - ๐ฌ๐งUnited Kingdom AndyF
Thanks everyone for the work on this. I hate to push the status back to needs review, but I think there's some unnecessary complexity in the previous patch as the base class already has the required service.
Not sure it's worth an interdiff with such a small patch.
Thanks!
- Status changed to RTBC
about 1 year ago 2:08pm 19 September 2023 - ๐บ๐ธUnited States SamLerner
Thank you @AndyF for your update, it's a much cleaner solution. Looks like it's already part of CKEditorPluginBase on https://www.drupal.org/node/2940438 โ
Tested your patch and it also works, thanks so much!
Putting back in RTBC since the update does the same thing as before, just without adding another service.
- ๐บ๐ธUnited States seattlehimay
#12 Tested and working for me too. Thanks!
- ๐จ๐ฆCanada joseph.olstad
I've sent a contact message to both of the maintainers. If they do not respond in another 2 weeks, dรฉclenche un virage
- Status changed to Fixed
12 months ago 6:17am 1 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.