- Issue created by @tobiasb
- @tobiasb opened merge request.
- Status changed to Needs review
over 1 year ago 1:33pm 25 October 2023 - First commit to issue fork.
- πΊπΈUnited States markdorison
Great catch @tobiasb. I have taken this opportunity to replace the empty() checks with a stricter empty string comparison, but if others feel strongly against this, we could roll that back.
- π«π·France ericdsd France
Thanks a lot for the workaround in description
- Status changed to RTBC
over 1 year ago 2:25pm 1 November 2023 - π³π±Netherlands ricovandevin
For us it also does not work when the local uses a custom path (sites/site-name/files) while the remote uses the default path (sites/default/files). This is caused by the fact that the check done is not
empty()
but!empty()
, probably by accident. This makes that the$remote_file_dir
is always set to the$file_dir
if a custom origin dir is configured. The change in the MR for this issue fixes this case too. - π©πͺGermany tobiasb Berlin
Another solution. Make origin_dir a required configuration and set origin_dir to sites/default/files via update hook.
- πΊπΈUnited States shelane
#10 does not work for multisites where the site path will be different for each.
- First commit to issue fork.
-
smustgrave β
committed 6c1e046c on 2.1.x authored by
tobiasb β
Issue #3396633: Proxy does not work anymore with a empty origin_dir...
-
smustgrave β
committed 6c1e046c on 2.1.x authored by
tobiasb β
- Status changed to Fixed
over 1 year ago 2:30pm 3 November 2023 - πΊπΈUnited States smustgrave
Merging this.
If we want an default could open a follow up for discussion.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 2:13pm 20 November 2023 - π§π·Brazil jkamizato
Hey guys, this works for me and I've created a patch file while new version is not released.