Drupal 11 compatability

I have pushed a commit to the issue form and created a merge request.
As far as PHP Stan could find there was only one deprecated item that needed fix which necessitates;

core_version_requirement: ^10.3 || ^11

Uploaded patch here for ease of use

new patch can be found by clicking on the "plain diff" link in the issue fork section:
https://git.drupalcode.org/project/adminimal_theme/-/merge_requests/15.diff

cc @jonasanne

Tested on:
- Drupal 11.0.1
- PHP 8.3.10
- MySQL 8.0.19

Verified:
- Adminimal can be installed in "Appearance"
- Adminimal can be used as the Administration theme
- Adminimal settings can be view and saved (/admin/appearance/settings/adminimal_theme)
- Creating and using the custom "adminimal-custom.css" overrides works as expected
- Layout is the same as the Drupal 10 version
- Tested different admin pages including node edit, block layout, and media library with no regressions seen

RTBC +1

note to maintainers - this commit drops support for Drupal 9 and Drupal 10.2 or less:

https://git.drupalcode.org/issue/adminimal_theme-3460890/-/commit/44327e...

thank you

ajit dalal → made their first commit to this issue’s fork.

Is there any chance we can get this merged in and D11 compatible version released?

I have verified MR !15 against Drupal 10.3 and Drupal 11, functionality is working as expected. Upgrade status is showing no error.

RTBC +1

Agree on merge request, this seems good to go. Can we get an official release out? Thanks.

Can we please get an official release for this?

++ on #16

thank you

How does this work without a base theme? Contrib Seven → doesn't have a Drupal 11 version yet 📌 Automated Drupal 11 compatibility fixes for seven Needs review , and it was removed from core in D11.

@imclean

I'm preparing the project to upgrate to D10, which mean, its not D11 yet. So, I upgrade Seven using patch

"patches": {
            "drupal/seven": {
                "Upgrade to Drupal 11": "https://git.drupalcode.org/project/seven/-/merge_requests/14.diff"
            },

Then added the fork to repository:

    "repositories": {
          "drupal/adminimal_theme": {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/adminimal_theme-3460890.git"
        },

In "require" section I configured this way:

"drupal/adminimal_admin_toolbar": "2.0.x-dev@dev",
"drupal/seven": "~1.0",

I think you can apply patch to adminimal_admin_toolbar as well and changing repository is not necessary.

Hope I could help you a bit.

Thanks, I got around the immediate problem by moving Adminimal and Seven under custom themes.

The main issue is how to progress this issue. There can't be an official D11 release before Seven has one.

@imclean

Got it. You are right. I think the only thing we can do is wait for Seven to be released to D11. But your approach is quite good

@imclean, I think I solved it.

Here the composer:

Add the repository for each fork (seven and adminimal)

    "repositories": {
        "drupal/seven": {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/seven-3434485.git"
        },
        "drupal/devel_entity_updates": {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/devel_entity_updates-3454902.git"
        },

Then add this in require:

"drupal/seven": "dev-3434485-d11-compatibility as 1.0.99",
"drupal/adminimal_theme": "dev-3460890-drupal-11-compatability",

Then run composer update

Hope it works for you.

For those who are trying to make adminimal_theme compatible with Drupal 11. I changed the composer.json file to allow drupal/seven package on version ~1.0(Which is compatible with Drupal 9 and 10), and version dev-2.0.x#1aca09a3(this dev branch is compatible with Drupal 11, unfortunatelly, it doesn't have any releases yet).

In order to require this module and make everything works correctly, I had to change my project's composer.json file to something like:

Repositories:

"repositories": {
    "drupal": {
      "type": "composer",
      "url": "https://packages.drupal.org/8",
      "exclude": ["drupal/adminimal_theme"]
    },
    "drupal/adminimal_theme": {
      "type": "vcs",
      "url": "https://git.drupalcode.org/issue/adminimal_theme-3460890.git"
    },
}

Require:

 "require": {
    "drupal/adminimal_theme": "dev-3460890-drupal-11-compatability#167c4a54bc",
  }

Stability

"minimum-stability": "dev"

I hope this helps someone, and once we have a Drupal 11 compatiblity release from drupal/seven → , we'll be able to update the MR from this issue and make this module compatible with Drupal 11.

Is there any possibility to get the D11 version instead of applying the patches and changing the core_version_requiremen or making changes in the composer.json file?