Sorry about the spam forgot the commits get directly posted here. I have rebased the branch so the patch applies.
Was unable to use patch from #6 so i made a commit with the changes from that patch with some minor changes like an update hook for the renaming of node_types to content_types.
After further looking into this it seems to have already been changed and fixed in https://www.drupal.org/project/office_hours/issues/3455636 📌 Use not-randomized drupal-data-selector, not #id Fixed
Added a new commit with a fix. I am unsure if this is the best solution however this solution definitely works from my own testing.
* Still need testing
Hikkypo → made their first commit to this issue’s fork.
Hikkypo → created an issue.
We had a website with nl-be and this patch worked for that too.
After thinking about this more i believe this to be the default interaction and working as designed and will close it as such
Hikkypo → created an issue.
Thanks @darvanen i have made an interdiff. I do not believe i had fixed many if any of the feedback you had given ill try to add that now
Thanks megachriss I hadnt seem that. It seems that this sorting is however only used for the settings form. So i do still think my solution is correct. But maybe the sorting needs to be expanded to be similar to the behaviour in pluginInstanceSort. However since this current implementation requires instances it seems difficult to adopt this behaviour without a second version of it that uses the definition arrays or a new sorting function. I also question if sorting by label is relevant for general use since the weight should be the primary sorting label sorting does not seem logical for this kind of functionality except for when presenting to a user.
Applied existing patch #65 to the fork and changed the warning message as suggested in #69 also added that the message shows on both access denied and if the route exists. Any non existant routes still have no message. I was not entirely sure where i could find the formatting standards so i did not make any changes to fix those.
Hikkypo → made their first commit to this issue’s fork.
Hikkypo → created an issue.
I am currently running into the same problem even when granting all possible permissions from userprotect it does not work.
Hello @znaeff I have tested your code and it works.
Resubmit patch but working this time
Added patch with php8 changes where usort expects numbers instead of booleans
Hello @znaeff I believe you are wrong about what the problem is. The issue is that getState could return null. The current way isUpdatingInProgress is handled does not account for this possibility. This is what my fix is trying to prevent. I am not trying to introduce isUpdatingInProgress as a new method i am aware this is an existing method.
Hikkypo → made their first commit to this issue’s fork.
Hikkypo → created an issue.
Added my vocabulary fix. Was trying to make a version that would be more inclusive but i could not find a way to get the proper entity types and vocabularies.
Attempted to redo this patch for version 7 and drupal 9.5