Validation issue on adding url redirect

Another +1 for #43 🐛 Validation issue on adding url redirect Needs review

#53 is working well for me!

Assigning to myself as I'm triaging all RTBC issues.

Several people have tested #53 and confirmed it's working for them. I do see that the tests were updated so that's good. I have confirmed that patch still applies.

I'm not seeing anyone who obviously reviewed the code in #53. So that's the next step here.

No more manual testing is needed.

I did a quick scan of the code but it still needs a proper code review.

Some nitpicks to fix:

1. +++ b/src/Form/RedirectForm.php
   @@ -143,6 +145,32 @@ class RedirectForm extends ContentEntityForm {
   +    // If creating a new Redirect and the source path is an existing path, recommend an alias instead.
   

   More than 80 chars.

2. +++ b/src/Form/RedirectForm.php
   @@ -143,6 +145,32 @@ class RedirectForm extends ContentEntityForm {
   +      //
   

   Empty comment.

3. +++ b/src/Form/RedirectForm.php
   @@ -143,6 +145,32 @@ class RedirectForm extends ContentEntityForm {
   +      // @todo Exception driven logic. Find a better way to determine if we have a valid path.
   

   More than 80 chars.

The code in #53 is basically the same as all previous patches, which have been through several rounds of review.

Fixing comment lengths.

Thanks @acbramley :)

No more manual testing is needed.

Still needs a proper code review.

The patch 3057250-65.patch is working fine , i have tried and tested it .

Reviewed code. One issue with AccessDeniedHttpException - with the catch in place, the user can create the redirect, but will not receive the warning that it's a valid path or the suggestion to use an alias instead. Is it possible for the user to get AccessDeniedHttpException for a path that doesn't exist?

If not, the same warning could be added inside the catch.

If so, the message could be modified to indicate that *if* it's a valid path an alias is recommended.

Applied existing patch #65 to the fork and changed the warning message as suggested in #69 also added that the message shows on both access denied and if the route exists. Any non existant routes still have no message. I was not entirely sure where i could find the formatting standards so i did not make any changes to fix those.

I'm not sure what's going on in #72 as the issue fork commit is identical to #65.

This patch is the same as #65 plus these additional changes:

* Allow the user to add a redirect from an internal path to an external URL without an unhelpful validation warning to consider using a URL alias instead.
* Remove some use statements from RedirectSourceWidget.php (their usage having been eliminated in previous revisions of this patch).

I applied the patch at #74 to the 8.x-1.x branch.

The module no longer presents the "unhelpful validation warning to consider using a URL alias instead" when adding a redirect from an internal path to an external URL.

The patch removes the unnecessary use statements, as indicated in the second point. 👍🏻

Allow the user to add a redirect from an internal path to an external URL without an unhelpful validation warning to consider using a URL alias instead.

Is this in scope for this issue? It sounds like it's separate.

I think it's in scope insofar as it's a regression of sorts -- the unpatched module doesn't hinder the user in the situation I've raised because the unhelpful warning message was displayed automatically using AJAX, before the form was even submitted.

With the patch, the warning doesn't happen until the user submits the form, which then means they now need to submit the form a second time to make it stick, when previously once was enough.

I.e. Because we've removed the AJAX in this patch, I think we need to also remove any false-positive warnings.

As noted in #9, this is a core issue 🐛 Submitting a form during an ajax request: field data not in $_POST. Needs work . The description in that ticket differs from this description, but it comes down to the same thing.
Can confirm that the core patch in comment 57 🐛 Submitting a form during an ajax request: field data not in $_POST. Needs work addresses the issue reported here.
I know that core issues can drag on forever (12 years and counting), but ideally any further efforts should go towards moving along the resolution there instead of in this module.

Attached a static redirect--2024-08-11--3057250-79.patch file
After Redirect 8.x-1.10 → was released

I was not able to push changes to the issue fork

This fixes this long-running bug, and I agree with #78 that it is prudent to fix this in the contrib module rather than wait for core to fix the underlying issue. Marking as RTBC.

That's OK with me, but this has no merge request, so tests didn't run. Please ensure there is a merge request with the latest and tested version of the patches here.

MR up and green.

I note that the functional change in #74 has been lost (it wasn't included in #79).

https://www.drupal.org/project/redirect/issues/3057250#comment-15524338 🐛 Validation issue on adding url redirect Needs review

Perhaps that issue was dealt with in some other way in the interim. Either way, it probably needs to be reviewed.

@jweowu sorry I missed that, feel free to contribute to the MR.

This is a major bug because if you spend time entering a url and then press submit you lose the URL you've just entered which is quite frustrating and data loss of a sort because you have to re-enter it completely. Also the problem is very bad if you add a redirect from an existing node because you have no reason to enter information in any other field.

If anyone is here looking for a temporary workaround, using the tab key instead of a mouse/trackpad worked for me.

I note that the functional change in #74 has been lost (it wasn't included in #79).

I added the additional check to the MR via https://git.drupalcode.org/project/redirect/-/merge_requests/133/diffs?c... .

This is again ready for review!

https://www.drupal.org/project/redirect/issues/3057250#comment-15723568 🐛 Validation issue on adding url redirect Needs review

Works perfectly with Drupal version 10.4.5 and Redirect module version 1.11.0.

tested latest MR with drupal 10.4.3 and redirect 1.11