bjc2265 → made their first commit to this issue’s fork.
I haven't been able to reproduce this. I followed steps using Drupal 10.2.1, Claro admin theme, in both Chrome and Firefox. I created a new content type and added a plain text field allowing up to 15 values (also tried with unlimited values). Form behaved as expected.
Is anyone able to reproduce this?
bjc2265 → created an issue.
Drupal 9 is now end-of-life.
Reviewing in Drupal 10, I'm unable to reorder any blocks in layout via dragging. I can still drag the element, but the yellow "destination" preview never moves from the original position. This occurs just by having the module enabled, even if no restrictions have been applied.
I am able to reorder blocks if I select the "move" option on an individual block within the layout. Reordering itself seems unaffected - the drag and drop interface seems to be where the failure occurs.
No dblog or console errors were generated.
Has anyone been able to reproduce this error in Drupal 9+? I've tested in D9 and D10 (with Claro theme), and with no patch there is error highlighting for checkboxes and radios (screenshots attached).
If nobody can reproduce, I think the patch can be strictly for 7-8. Might also want to use the same style implemented in Claro, where the lines of the bubbles/boxes are highlighted red (focus indicator appears around the inputs).
Reviewed code. One issue with AccessDeniedHttpException - with the catch in place, the user can create the redirect, but will not receive the warning that it's a valid path or the suggestion to use an alias instead. Is it possible for the user to get AccessDeniedHttpException for a path that doesn't exist?
If not, the same warning could be added inside the catch.
If so, the message could be modified to indicate that *if* it's a valid path an alias is recommended.
It looks like 2.0.0 has has a dependency syntax error which was resolved in 2.0.1: https://git.drupalcode.org/project/bootstrap_horizontal_tabs/-/commit/ea...
I'm not sure why ^2.0 is returning 2.0.0 for you. Does it detect 2.0.4 if you specify it?
Agree with #11 and #14. A conditional tied to a Bootstrap version selector would be a good fix.
Looking at #3 I confirmed that the data-bs-toggle data-toggle attributes can both be included without issue. However, I've been unable to find any way to get Bootstrap 3 and 4 working without the <li> wrapper, or any way to get Bootstrap 5 working without removing it.
The changes required by 🐛 Tab is not working in Bootstrap 5 Needs work do break things in 3 and 4. I agree that a configuration option indicating which version is being used would be a good fix.
I've tested and confirmed that #8 fixes this specific issue without impeding anything in Bootstrap 4 or 5, so this change doesn't need to be conditional and can be merged now.
This patch should work with Bootstrap 3, 4, and 5. It might be too narrowly scoped - it removes the <li> tag if the name of the theme is "bootstrap5". Not sure if there's a way to make it recognize any theme using Bootstrap 5.
I've confirmed that the tabs can have both data-toggle and data-bs-toggle without issue. If there's a way to fix the multiple active tab problem without removing
Correction to #10 - the bug with Bootstrap 5 happens even without the patch, as described here 🐛 Tab is not working in Bootstrap 5 Needs work . I've also confirmed that it still works with Bootstrap 4.
Tested #8 - resolves issue in Bootstrap 3, but makes tab buttons non-functional in Bootstrap 5.
Using PHP 8.1.8 and Drupal 10.1.4
Just to confirm: message should appear in GUI after going to Extend tab, selecting a module that changes configuration (such as Configuration Translation or Content Translation) and clicking Install? Because doing that on fresh install I'm not seeing error in logs or as alert.
I've been unable to reproduce this by enabling modules. Attempted several contrib modules (including ckeditor 4 and 5) in fresh Drupal 10.1.x install.
This patch adds custom ids to search field and submit field (google-cse-query and google-cse-submit respectively).
Apologies, this patch should resolve the issue.
I wasn't able to reproduce, but this patch will prevent ["#bundle"] from being called if it does not exist.
Updated patch in #9 does achieve result in a cleaner way.
This patch changes bootstrap_horizontal_tabs\Plugin\Field\FieldFormatter\BootstrapHorizontalTabs::viewElements so that it leaves $elements array empty if there is no data in field.