Querying with NULL values results in warning mb_strtolower(): Passing null to parameter is deprecated

Have to be in agreement with @jungle in #19. Seems this patch was just covering a symptom but the cause has been fixed.

If anyone disagrees please reopen with an explanation why.

Thanks!

I wonder if closing won't fix is quite what we want to do? Could we complain more loudly or do something to help track down these issues? I regularly see these warnings in test runs and its a bear to figure out where the null is coming from. Being more loud in our logging of the source would be really nice.

We're seeing these warning show up in various contexts when using exported configuration entities provided by custom modules in config/install directories that do not have UUIDs. It looks like the Drupal\Core\Config\Entity\ConfigEntityBase::preSave() method uses Drupal\Core\Entity\EntityBase::uuid() which returns NULL if a UUID doesn't exist.

The attached patch changes those NULL values into empty strings in Drupal\Core\Config\Entity\ConfigEntityBase::preSave() to prevent them from getting passed as query condition values.

The issue summary should be updated with the new proposed solution.

Will also require a test case to show the problem.

Got this notice in D10 using php 8.1 when switching text format from ckeditor5 to ckeditor4
patch 25 resolves the issue.

Hi!
I confirm that #13 fixed the issue for me on Drupal 9.5.9 with php 8.1.
Thank you!

Part of why this is becoming an issue, more and more is because of 🐛 'filter.format.' . WebformHtmlEditor::DEFAULT_FILTER_FORMAT missing UUID Fixed .

kindly review the patch.

Still needs tests and issue summary update

Please review the Patch

Added a new patch. Fixing build issue. Please review

Rerolled patch #36, please review it.

Thanks!

Thank you for the interest but please read the tags. Previously tagged for issue summary update and tests.

Also the MR is on the correct branch and should continue there.

"Needs tests"

Still needs a test.

Merge request !4263 fixed my issue on Drupal 10.1.2 (PHP 8.1.14 / MySQL 5.7.29)

Thanks.

I've been unable to reproduce this by enabling modules. Attempted several contrib modules (including ckeditor 4 and 5) in fresh Drupal 10.1.x install.

@bjc2265, are you using PHP 8.0 or PHP 8.1+ ?

This fix is for PHP 8.1+

Using PHP 8.1.8 and Drupal 10.1.4

Just to confirm: message should appear in GUI after going to Extend tab, selecting a module that changes configuration (such as Configuration Translation or Content Translation) and clicking Install? Because doing that on fresh install I'm not seeing error in logs or as alert.

I don't know how to do test only patches with gitlab. I also was not able to "claim" push access to the fork

Anyway. Here is a test only patch, please feel free to add to the fork

If you click "Get push access" there's an option on the pipeline https://git.drupalcode.org/issue/drupal-3302838/-/pipelines/56031

There you can click "Test-only feature"

Current MR appears to have test failures.

Was previously tagged for issue summary too as some sections appear to be missing.

I did click the "get push access" and have done so many times before as well. But some hiccup today probably? Tried again now, and now it works :)

Let me try to rebase and get the test only thing in there as well, never tried that before.

Leaving on NW for the issue summary part

Now will say there's a bug/feature being worked out where if the MR is opened by a core committer, even getting push access you can't run the test-only feature or rerun any tests.

right. was probably just a hiccup I guess, since both work now.

Link to test-only run: https://git.drupalcode.org/issue/drupal-3302838/-/jobs/799034

Removing tests tag

updated issue summary

As per #18 this is fixing the symptom and not the cause. If a config entity is missing a UUID then a module is doing something wrong. The configuration is not valid.