Account created on 28 July 2017, almost 7 years ago
#

Merge Requests

More

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

suryabhi โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

suryabhi โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

suryabhi โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Please mark as fixed of this issue @shashank5563

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi
๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

suryabhi โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

suryabhi โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Hi @urvashi_vora, the patch applied to user who raised the issue. I don't know of whom we are waiting to fixed the issue. its been 4 weeks the raised the PR https://git.drupalcode.org/project/sitewide_alert/-/merge_requests/38 but still it is open. Unable to understand the process.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Above patch created from '2.0.x dev' branch. if this won't work then I have created from '2.0.0-alpha1' branch. This should work for alpha version

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Created a patch to remove leading zero. Please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

suryabhi โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

I tried different approach in the recent. Kindly review

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Patches is against the alpha version while Merge request is against the dev branch. Previously i was created patch from dev branch and codebase is on alpha version so it was not getting applied thats why i have created patch from alpha branch and now it is working.
@tim-diels

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

suryabhi โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Comment addressed. Added in new update hook.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Added cache max age value in .install file. Comment addressed!

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Kindly review. Addressing PR comment.

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

Added a patch. please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia suryabhi

suryabhi โ†’ made their first commit to this issueโ€™s fork.

Production build 0.69.0 2024