- 🇬🇧United Kingdom manarth
I've approached it in a slightly different direction, adding "presave" and "postsave" operations (callables) to the FeedsItem. This allows each target to provide and encapsulate its data and functionality needs in a generic way.
- 🇬🇧United Kingdom manarth
Updated patch with interface and missing FeedsItem implementation.
- 🇳🇱Netherlands megachriz
Nice implementation! I do wonder if it is safe to use
$feeds_item = $entity->get('feeds_item')->first();
, because a feed item can be multivalued. Multiple imports can run simultaneously (and update the same content), so I wonder if there's a possibility that these imports could clash with eachother. The alternative to use would be$feeds_item = $entity->get('feeds_item')->getItemByFeed($feed);
.Do you want to work on tests too? See #3.
- last update
over 1 year ago 701 pass - 🇮🇳India suryabhi
After removing .info.yml from https://www.drupal.org/files/issues/2023-04-18/3060308.10.add-changed-ma... → . it is working as expected
- 🇺🇸United States msypes
Here's a version of the patch in #10 without the changes to the .info.yml file, as mentioned in #12
- Status changed to Fixed
over 1 year ago 6:01pm 7 July 2023 - Status changed to Needs work
over 1 year ago 6:11pm 7 July 2023 - 🇳🇱Netherlands megachriz
@suryabhi
Thanks for reporting that the patch worked for you! :) Note that the status "Fixed" means that an issue has been resolved. In this particular case that would mean that the patch was committed. This didn't happen yet, so I set the status back to "Needs work". It needs work because automated tests are still needed. Tests make sure that the feature keeps working as intended, because these run after every change that is committed to Feeds. - last update
over 1 year ago 701 pass - last update
over 1 year ago 701 pass - @suryabhi opened merge request.
- 🇮🇳India suryabhi
Raised the new merge request. Please review @ https://www.drupal.org/u/megachriz →
- Status changed to Needs review
over 1 year ago 2:12pm 16 July 2023 - last update
over 1 year ago 401 pass, 130 fail - last update
over 1 year ago 701 pass - last update
over 1 year ago 701 pass The last submitted patch, 9: 3060308.9.add-changed-mapping.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Fixed
over 1 year ago 9:49am 25 July 2023 - Status changed to Needs work
over 1 year ago 12:05pm 25 July 2023 - 🇳🇱Netherlands megachriz
@suryabhi
The status "Fixed" should only be used when an issue is resolved. For more information about the issue status field, see https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →I set the status to "Needs work" because automated tests are still needed.
- 🇮🇳India sagar ramgade
I tested the patch, but it didn't work for me. Some of the entities didn't respect the mapped value. I have a few more importers for importing the same content type and there are a few feed items which updated several nodes data. The fact that we are just picking the first feed item seems wrong "$feeds_item = $entity->get('feeds_item')->first();" and hence leaving few of the nodes.