🇮🇳India @sagar ramgade

sagar ramgade → created an issue.

Re-rolled the patch for 3.1.33.

Here's a patch that is re-roll of #8 on 2.24.

I tested the patch, but it didn't work for me. Some of the entities didn't respect the mapped value. I have a few more importers for importing the same content type and there are a few feed items which updated several nodes data. The fact that we are just picking the first feed item seems wrong "$feeds_item = $entity->get('feeds_item')->first();" and hence leaving few of the nodes.

Sagar Ramgade → made their first commit to this issue’s fork.

Thanks @sarwan_verma, overall it looks good. I've pushed some minor text changes.

Sagar Ramgade → created an issue.

The merge request fixes the following notice:

Unsilenced deprecation notices (9)

  3x: Creation of dynamic property Drupal\Tests\trailless_menu\Functional\TraillessMenuTest::$block is deprecated
    1x in TraillessMenuTest::testTraillessMenuLink from Drupal\Tests\trailless_menu\Functional
    1x in TraillessMenuTest::testRenderHappensOnceForTraillessMenu from Drupal\Tests\trailless_menu\Functional
    1x in TraillessMenuTest::testCacheInvalidationOnFormSave from Drupal\Tests\trailless_menu\Functional

  3x: Creation of dynamic property Drupal\Tests\trailless_menu\Functional\TraillessMenuTest::$first_item is deprecated
    1x in TraillessMenuTest::testTraillessMenuLink from Drupal\Tests\trailless_menu\Functional
    1x in TraillessMenuTest::testRenderHappensOnceForTraillessMenu from Drupal\Tests\trailless_menu\Functional
    1x in TraillessMenuTest::testCacheInvalidationOnFormSave from Drupal\Tests\trailless_menu\Functional

  3x: Creation of dynamic property Drupal\Tests\trailless_menu\Functional\TraillessMenuTest::$second_item is deprecated
    1x in TraillessMenuTest::testTraillessMenuLink from Drupal\Tests\trailless_menu\Functional
    1x in TraillessMenuTest::testRenderHappensOnceForTraillessMenu from Drupal\Tests\trailless_menu\Functional
    1x in TraillessMenuTest::testCacheInvalidationOnFormSave from Drupal\Tests\trailless_menu\Functional

Sagar Ramgade → made their first commit to this issue’s fork.

Sagar Ramgade → created an issue.

Sagar Ramgade → created an issue.