sitewide_alert cache max age value is hard coded

Added a patch. please review

Kindly review. Addressing PR comment.

Hi Abhishek,

Your recent patch worked for me.

Thankyou so much.

This looks good. Do we need provide some sort of update hook to set the config value to 15 for those updating the module? We may want to update the description of the settings form to inform the site admin what the setting impacts and sugesst a recommended setting.

Added cache max age value in .install file. Comment addressed!

Comment addressed. Added in new update hook.

@suryabhi… You can not set issues fixed yourself when providing patches. Mostly maintainers set it fixed when actually committed.

This issue is fixed now

Hi @suryabhi as @tim-does already notify you that you can't change the issue status to "Fixed" by yourself, until and unless the patch is committed. Please wait for the maintainers to commit the changes.

Setting it back to 'Reviewed and Tested by Community'.

Hi @urvashi_vora, the patch applied to user who raised the issue. I don't know of whom we are waiting to fixed the issue. its been 4 weeks the raised the PR https://git.drupalcode.org/project/sitewide_alert/-/merge_requests/38 but still it is open. Unable to understand the process.

I suggest reading through the documentation https://www.drupal.org/community/contributor-guide/reference-information... →

An issue is set to fixed when the maintainer has seen the issue, tested it and applied it to the code. Mostly a new release of the module will be made so you don’t need the patch anymore.

It can take a while for maintainers to do this as most of the time these people are investing their own free time to maintain modules. So please give it some time and when nothing happens, you can contact t the maintainer to try to speed things up. But beware to not spam them. If nothing happens, you can always contact me on slack or through Drupal and I’ll see what I can do.

Hi @suryabhi,

The patch applied to user who raised the issue.

Indeed, the patch works well, thus the issue is marked as RTBC.

I don't know of whom we are waiting to fixed the issue.

We are waiting for the maintainers to commit the changes into the project repo as they might be busy with lots of work assigned to them (thus, we are expected to have patience after contributing, some issues get fixed in a day and some takes time). Once the code is committed, maintainers are required to grant credit and set the issue as 'Fixed'.

Its been 4 weeks the raised the PR https://git.drupalcode.org/project/sitewide_alert/-/merge_requests/38 but still it is open. Unable to understand the process.

Well in that case, if u want the issue to be taken care at high priority you can ping the maintainers (@ChrisSnyder or @bygeoffthompson) in slack. I believe your issue would be fixed early.

Hope you understand the right path now.

Thanks

I appreciate all of the work on this issue. I have some time later this week that I hope to work on some contrib projects. I'll try to get this work committed.

Automatically closed - issue fixed for 2 weeks with no activity.