- Issue created by @heddn
- Status changed to Needs review
about 1 year ago 4:41pm 23 June 2023 - last update
about 1 year ago 534 pass - heddn Nicaragua
See 🐛 Querying with NULL values results in warning mb_strtolower(): Passing null to parameter is deprecated Needs work for what this causes.
- last update
about 1 year ago 534 pass - 🇺🇸United States jrockowitz Brooklyn, NY
I did not have time to reproduce the issue but the attached patch might address the root cause which is don't alter config when config is being sync'd
- Status changed to Needs work
about 1 year ago 2:30pm 28 June 2023 - heddn Nicaragua
I get the following with the patch in #4:
1) Drupal\Tests\install_profile\Functional\InstallProfileTest::testInstall editor.editor.webform_default: Drupal\Component\Diff\Engine\DiffOpChange::__set_state(array( 'type' => 'change', 'orig' => array ( 0 => 'uuid: null', ), 'closing' => array ( 0 => 'uuid: 94ff9c7f-4743-4b76-a020-5d83cf93b3ba', ), ))
I got no error with the patch in #2.
- 🇺🇸United States jrockowitz Brooklyn, NY
I am open to patch #2, I am assuming the filter.format.webform_default does get assigned a UUID.
- heddn Nicaragua
If you assign a UUID in your exported config, it will get overridden when the exported config is executed. Ideally #2 would assign a unique UUID to the config as it is inserting into the DB. Otherwise, it is gets inserted as a null value and site admins have to ignore the warnings from #3.
- Status changed to RTBC
11 months ago 1:23pm 5 October 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
Moving this to critical because it should be a release blocker.
@hedden I am fine with your recommendation from #4.
I am changing this to RTBC so that https://www.drupal.org/files/issues/2023-06-23/3369127.patch → can be merged.
- last update
11 months ago 536 pass - last update
11 months ago Fetch save error -
Liam Morland →
committed d4b760bb on 6.2.x authored by
heddn →
Issue #3369127 by heddn, jrockowitz: Add missing UUID to 'filter.format...
-
Liam Morland →
committed d4b760bb on 6.2.x authored by
heddn →
- Status changed to Fixed
11 months ago 2:49pm 5 October 2023 - Status changed to Needs review
11 months ago 2:18pm 11 October 2023 - last update
11 months ago 536 pass - 🇩🇪Germany hchonov 🇪🇺🇩🇪🇧🇬
The real issue here is that
_webform_update_html_editor()
is using the config storage directly to write the config and thus leaving the config without an UUID. We identified this since we use the config_plus → module that has a protection against saving configs without an UUID. The UUID is being added to an entity only when using the entity storage to save the entity. Therefore we should not be using the config storage here to create config entities but rather the config entity storage. I am attaching a patch that properly installs the config entities. - Status changed to RTBC
11 months ago 3:41pm 11 October 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
@hchonov Thank you for swopping in and saving the day. Your patch looks fine to me.
- last update
11 months ago 536 pass - last update
11 months ago 536 pass -
Liam Morland →
committed 948dbf83 on 6.2.x authored by
hchonov →
Issue #3369127 by jrockowitz, hchonov: Create config entities before...
-
Liam Morland →
committed 948dbf83 on 6.2.x authored by
hchonov →
- Status changed to Fixed
11 months ago 5:22pm 11 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.