I am adding another related issue as the solutions are the same.
I'm updating the MR to include the is_string validation since the function mb_strtolower expects a string as parameter.
hfernandes → made their first commit to this issue’s fork.
@jrockowitz, would it make sense to merge both developments into a single MR? The ✨ [Performance] Add an index on webform_submission_data name and property Needs review issue introduces an index on the 'name' and 'property' values, while this MR adds an index on 'name' and 'webform_id.'.
hfernandes → created an issue.
Attaching the patch and opening the MR.
hfernandes → created an issue.
I've submitted the PR to Docksal as well: https://github.com/docksal/service-nginx/issues/22
MR opened.
hfernandes → created an issue.
I noticed that with the `if`, the `loop.index` wasn't counting correctly, so I changed it to use the `filter` filter instead.
Here is one example, the first accordion item should be open by default. With the `if` approach, it wasn't.
Using `filter`:
Moving it back to `Needs Review`.
hfernandes → made their first commit to this issue’s fork.
I've just installed this module and faced this issue.
Applying this patch I can confirm this issue has been fixed.
My setup:
- Drupal: 9.5.2
- Module version: 8.x-3.8
Adding the patch file.
MR created.
hfernandes → created an issue.
I did some tests and it's working as designed.
Note: if you have "Force image usage only" unchecked and disable the browser's Javascript, it loads properly (see attached).
MR created and patch tested.
Working as expected.
hfernandes → made their first commit to this issue’s fork.
I've fixed the MR https://git.drupalcode.org/project/drupal/-/merge_requests/2537
Also attaching the generated patch for Drupal 9.5 here.
hfernandes → made their first commit to this issue’s fork.