🇮🇳India @PrabuEla

Hi @hamzadwaya,

I am not able to reproduce the issue. I have added a time field and saved the node. It is saving without any error.

Can any one spend a bit time to test this module

@RobertoGuzman

How to reproduce the error my PHP and drupal version are as below
Drupal Version: 10.2.6
PHP Version: 8.1.28

@dzastin, I don't face the issue which you have mentioned.
@Indranil Roy, Once the module was installed via composer and enabled via drush. The page gets breaks for me.

Error: Interface "OAuth2\OpenID\Storage\AuthorizationCodeInterface" not found in include() (line 19 of /app/web/modules/contrib/oauth2_server/src/OAuth2StorageInterface.php)
#0 /app/vendor/composer/ClassLoader.php(576): include()
#1 /app/vendor/composer/ClassLoader.php(427): Composer\Autoload\{closure}('/app/web/module...')
#2 /app/web/modules/contrib/oauth2_server/src/OAuth2Storage.php(21): Composer\Autoload\ClassLoader->loadClass('Drupal\\oauth2_s...')
#3 /app/vendor/composer/ClassLoader.php(576): include('/app/web/module...')
#4 /app/vendor/composer/ClassLoader.php(427): Composer\Autoload\{closure}('/app/web/module...')
#5 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(259): Composer\Autoload\ClassLoader->loadClass('Drupal\\oauth2_s...')
#6 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'oauth2_server.s...')
#7 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('oauth2_server.s...', 1)
#8 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#9 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'authentication....')
#10 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('authentication....', 1)
#11 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#12 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(455): Drupal\Component\DependencyInjection\Container->createService(Array, 'private__DimxxC...')
#13 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(273): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#14 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'page_cache_requ...')
#15 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('page_cache_requ...', 1)
#16 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#17 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'http_middleware...')
#18 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('http_middleware...', 1)
#19 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#20 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'http_middleware...')
#21 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('http_middleware...', 1)
#22 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#23 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'http_middleware...')
#24 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440):

We will create another issue. If this is replicated by any other. Else we need bit more information for the issue.

Index Out of Bounds:

$values[array_rand($values)]:
This method will always generate a valid index within the bounds of the array.

$values[rand(0, count($values))]:
This can potentially generate an index equal to count($values), which is out of bounds and will cause an error.
Performance and Readability:

$values[array_rand($values)]:
This method is more readable and clearly conveys the intent of selecting a random element from the array.
$values[rand(0, count($values))]:
Even if corrected to $values[rand(0, count($values) - 1)], it is less readable and more error-prone.
Correct and Safe Usage:
Preferred Method: $values[array_rand($values)]
This ensures that a valid index is always selected, preventing any potential index out-of-bounds errors.

Please correct me if I am wrong.

Adding the diff files in the patch

Hi Can you please try with the patch.
end($image)->id() this will always return bool value if empty

PrabuEla → created an issue.

The dependency has been removed earlier. Just moving it to needs review

@smustgrave

I am not sure is it right. I have enabled the book module but the plugin is not visible in sitemap config page

As we have the alternate module for this. Do you thing is this need? @Collins405

Replaced by:
Contact Storage
With Drupal core's Contact module are the most direct Drupal 8 replacement

Hi @aaron.ferris

I have switched to your branch and executed upgrade status scan once again. I found some issue in the scan. Attaching below. Please correct me if I am wrong.

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Flag
Scanned on Tue, 05/14/2024 - 08:41.

3 warnings found.

web/modules/contrib/flag/src/Plugin/views/relationship/FlagViewsRelationship.php:
+-----------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+-----------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Fix
later | 148 | Call to deprecated function user_roles(). Deprecated in
drupal:10.2.0 and is removed from drupal:11.0.0. Use
Drupal\user\Entity\Role::loadMultiple() and, if necessary,
an inline implementation instead.
|
+-----------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/flag/tests/src/Functional/AdminUITest.php:
+----------------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+----------------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Check
manually | 188 | Relying on entity queries to check access by default is
deprecated in drupal:9.2.0 and an error will be thrown from
drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
TRUE or FALSE to specify whether access should be checked.
|
| Check
manually | 204 | Relying on entity queries to check access by default is
deprecated in drupal:9.2.0 and an error will be thrown from
drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
TRUE or FALSE to specify whether access should be checked.
|
+----------------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

PrabuEla → created an issue.

Rebased the latest changes of 8.x-3.x

As stated in Proposed resolution, removed is safe params

PrabuEla → created an issue.

Note:

I have used below need to be tested is it working or not.

-use Twig_Extension;
-use Twig_SimpleFilter;
+use Twig\Extension\AbstractExtension;
+use Twig\TwigFilter;

/**
* Twig extension to encrypt phone links.
*/
-class KryptExtension extends Twig_Extension {
+class KryptExtension extends AbstractExtension {

- return array(
- new Twig_SimpleFilter('krypt', 'str_krypt'),
- );
+ return [
+ new TwigFilter('krypt', 'str_krypt'),
+ ];

@project maintainer.