chennai
Account created on 9 July 2019, over 5 years ago
#

Merge Requests

More

Recent comments

🇮🇳India PrabuEla chennai

PrabuEla made their first commit to this issue’s fork.

🇮🇳India PrabuEla chennai

PrabuEla made their first commit to this issue’s fork.

🇮🇳India PrabuEla chennai

@Tirupati_Singh
I have not applied the patch, I cloned the module switched to the latest MR branch and tried to add a fix but I found that the fix was already added. So I have shared a screenshot.

🇮🇳India PrabuEla chennai

@adam_b
As suggested, one more field in the config form is added and that holds the error message.

🇮🇳India PrabuEla chennai

@nicholasThompson Event I have tried it is not reproducible. Please provide the steps to reproduce.

🇮🇳India PrabuEla chennai

PrabuEla made their first commit to this issue’s fork.

🇮🇳India PrabuEla chennai

Hi @sclsweb

I was not able to reproduce the issue.
Drupal Version:10.3

PHP: 8.2

🇮🇳India PrabuEla chennai

Hi @lukus
I am not able to reproduce the issue. Can you please give some more details else lets wait for any other to reproduce the issue.

🇮🇳India PrabuEla chennai

Added the suggestion in the same PR. It is just a small change and credit is to @hanoii

🇮🇳India PrabuEla chennai

PrabuEla changed the visibility of the branch 3367294-log-data-export to active.

🇮🇳India PrabuEla chennai

PrabuEla changed the visibility of the branch 3367294-log-data-export to hidden.

🇮🇳India PrabuEla chennai

PrabuEla changed the visibility of the branch 3367294-log-data-export to hidden.

🇮🇳India PrabuEla chennai

@Kristen Pol
I have tested with the plain Drupal 10.3 with PHP version 8.2.
CivicTheme requires drupal/components ^3@beta
and JSON API isn't needed.

May the issue you are facing with some other module requiring JSON API in your project.

If I am not wrong this is not a valid issue. Please close this.

🇮🇳India PrabuEla chennai

Hi @hamzadwaya,

I am not able to reproduce the issue. I have added a time field and saved the node. It is saving without any error.

🇮🇳India PrabuEla chennai

Can any one spend a bit time to test this module

🇮🇳India PrabuEla chennai

@RobertoGuzman

How to reproduce the error my PHP and drupal version are as below
Drupal Version: 10.2.6
PHP Version: 8.1.28

🇮🇳India PrabuEla chennai

@dzastin, I don't face the issue which you have mentioned.
@Indranil Roy, Once the module was installed via composer and enabled via drush. The page gets breaks for me.

Error: Interface "OAuth2\OpenID\Storage\AuthorizationCodeInterface" not found in include() (line 19 of /app/web/modules/contrib/oauth2_server/src/OAuth2StorageInterface.php)
#0 /app/vendor/composer/ClassLoader.php(576): include()
#1 /app/vendor/composer/ClassLoader.php(427): Composer\Autoload\{closure}('/app/web/module...')
#2 /app/web/modules/contrib/oauth2_server/src/OAuth2Storage.php(21): Composer\Autoload\ClassLoader->loadClass('Drupal\\oauth2_s...')
#3 /app/vendor/composer/ClassLoader.php(576): include('/app/web/module...')
#4 /app/vendor/composer/ClassLoader.php(427): Composer\Autoload\{closure}('/app/web/module...')
#5 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(259): Composer\Autoload\ClassLoader->loadClass('Drupal\\oauth2_s...')
#6 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'oauth2_server.s...')
#7 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('oauth2_server.s...', 1)
#8 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#9 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'authentication....')
#10 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('authentication....', 1)
#11 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#12 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(455): Drupal\Component\DependencyInjection\Container->createService(Array, 'private__DimxxC...')
#13 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(273): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#14 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'page_cache_requ...')
#15 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('page_cache_requ...', 1)
#16 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#17 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'http_middleware...')
#18 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('http_middleware...', 1)
#19 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#20 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'http_middleware...')
#21 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440): Drupal\Component\DependencyInjection\Container->get('http_middleware...', 1)
#22 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#23 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService(Array, 'http_middleware...')
#24 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(440):

We will create another issue. If this is replicated by any other. Else we need bit more information for the issue.

🇮🇳India PrabuEla chennai

Index Out of Bounds:

$values[array_rand($values)]:
This method will always generate a valid index within the bounds of the array.

$values[rand(0, count($values))]:
This can potentially generate an index equal to count($values), which is out of bounds and will cause an error.
Performance and Readability:

$values[array_rand($values)]:
This method is more readable and clearly conveys the intent of selecting a random element from the array.
$values[rand(0, count($values))]:
Even if corrected to $values[rand(0, count($values) - 1)], it is less readable and more error-prone.
Correct and Safe Usage:
Preferred Method: $values[array_rand($values)]
This ensures that a valid index is always selected, preventing any potential index out-of-bounds errors.

Please correct me if I am wrong.

🇮🇳India PrabuEla chennai

Hi Can you please try with the patch.
end($image)->id() this will always return bool value if empty

🇮🇳India PrabuEla chennai

The dependency has been removed earlier. Just moving it to needs review

Production build 0.71.5 2024