- Issue created by @hanoii
- last update
5 months ago 8 pass - Assigned to hanoii
- Status changed to Needs review
5 months ago 8:14pm 16 June 2024 - Issue was unassigned.
- 🇩🇪Germany Anybody Porta Westfalica
Whao, that's nice, thank you @hanoii!
I'd vote for a 3.x semver branch to include this, what do the maintainers think?
- 🇦🇷Argentina hanoii 🇦🇷UTC-3
Thanks! I thought about that, but I figured that that the change is very minimal that it would make it a burden to have to maintain two separate branches for some time only for this change unless there's a strong opinion that 2.x would is EOL and all will happen in a new 3.x.
- 🇩🇪Germany Anybody Porta Westfalica
Yes I think we could do it like that, but let's wait for maintainer reply.
- Status changed to Needs work
5 months ago 6:28pm 25 June 2024 - 🇺🇸United States pookmish
I like this new approach. I hope it solves the s3 issue as well.
A couple things to change in the MR:
add docblock & return type to the new getDirectoryUri method
There's no need for the "else" condition. Something like below will be more streamlined.if($is_true) { return 'foo'; } return 'bar';
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
5 months ago Waiting for branch to pass - Status changed to Needs review
5 months ago 9:26pm 25 June 2024 - Status changed to Needs work
5 months ago 10:56am 26 June 2024 - Assigned to PrabuEla
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
5 months ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
5 months ago 11:33am 26 June 2024 - 🇮🇳India PrabuEla chennai
Added the suggestion in the same PR. It is just a small change and credit is to @hanoii
-
pookmish →
committed 4b5dec6b on 8.x-2.x
Issue #3454952 by hanoii, PrabuEla, Anybody: Support the new assets...
-
pookmish →
committed 4b5dec6b on 8.x-2.x
- Status changed to Fixed
5 months ago 8:29pm 5 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.