- Issue created by @prashant.c
- Assigned to PrabuEla
- Merge request !8517Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false positive → (Open) created by PrabuEla
- Status changed to Needs review
5 months ago 10:41am 24 June 2024 - last update
5 months ago Patch Failed to Apply - Status changed to Needs work
5 months ago 10:49am 24 June 2024 - Issue was unassigned.
- Assigned to PrabuEla
- Merge request !8521Issue #3456639: Add check if "services.yml" file exists → (Open) created by PrabuEla
- 🇮🇳India PrabuEla chennai
@cilefen
Created MR:
https://git.drupalcode.org/project/drupal/-/merge_requests/8521 - Issue was unassigned.
- Status changed to Needs review
5 months ago 1:55pm 24 June 2024 - Status changed to Needs work
5 months ago 2:10pm 24 June 2024 - 🇺🇸United States smustgrave
Not sure I fully see the issue here, is it causing an error?
MR has a number of failures so not ready for review yet.
If it's a change we go with believe test coverage should be added and with comments about why the check is needed.
- 🇮🇳India prashant.c Dharamshala
@smustgrave
There isn't an error, but currently, IMO the code is a bit misleading. If the check isn't present, the included file
services.ymlshould be present in the codebase by default. Without the check, the included file should be/sites/default/default.services.ymlinstead ofservices.yml