🇺🇸United States @tbcs

tbcs → created an issue.

Removing shell_exec version in most recent version as unlikely to seriously encounter a performance problem when configured correctly

Fixed this in the most recent version

tbcs → made their first commit to this issue’s fork.

tbcs → made their first commit to this issue’s fork.

Fixed manually

I appreciate it, thank you both

I'm still getting this behavior in 5.0.x. Like the others I've followed the guide to a T. If I manually insert the access and refresh token from postman (`https://login.salesforce.com/services/oauth2/token?grant_type=authorizat...`) I can access the API, but whenever I try to save the configuration form I get the same error.

The fundamental issue behind this is that the ckeditor5_language plugin requires that you are able to *edit* span tags, but does not guarantee that you can create them. Only the "Source Editing" plugin allows this. It's not always desirable to allow users to edit the source even when they can set language tags.

Is it reasonable to update ckeditor5.ckeditor5.yml to read like this?

ckeditor5_language:
  ckeditor5:
    plugins: [language.TextPartLanguage]
  drupal:
    label: Language
    library: ckeditor5/internal.ckeditor5.language
    admin_library: ckeditor5/internal.admin.language
    class: Drupal\ckeditor5\Plugin\CKEditor5Plugin\Language
    toolbar_items:
      textPartLanguage:
        label: Language
    elements:
      - <span>
      - <span lang dir>

Changes would also have to be made to the relevant tests, notably Drupal\Tests\ckeditor5\FunctionalJavascript\AdminUITest and Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5Test

See also https://www.drupal.org/node/3283526#comment-15391076 →

It seems that the core ckeditor5_language plugin should be updated thusly:

elements:
- <span>
- <span lang dir>

Right now if you want to enable the language plugin but do not want to enable source editing, you have no options. The following error appears:

"The Language plugin needs another plugin to create , for it to be able to create the following attributes: . Enable a plugin that supports creating this tag. If none exists, you can configure the Source Editing plugin to support it."

This is confusing. See https://www.drupal.org/project/drupal/issues/3388978 🐛 Eliminate or improve error upon adding the language plug-in Active

It seems natural to allow the language plugin to also create the tag it may modify.

Is there any problem with this?

Thanks, I appreciate this solution. While I wouldn't use it for a widely-distributed module it's helping us with our internal modules during the transition.

I'll take this.

Another +1 for #43 🐛 Validation issue on adding url redirect Needs review