- last update
over 1 year ago Custom Commands Failed - Status changed to Needs work
over 1 year ago 5:37pm 7 September 2023 - ๐บ๐ธUnited States smustgrave
#49 called for issue summary update which believe still needs to happen.
- ๐ฎ๐ณIndia gauravvvv Delhi, India
Fixed, CCF in #55. Attached interdiff for same. leaving as NW, as issue summary still needs to update.
- last update
over 1 year ago 30,147 pass - ๐บ๐ธUnited States capysara
I updated the IS and title based on the discussion to date and my assessment of the issue. The summary of my summary is: there isnโt sufficient support for the original proposed solution as a core fix, but there is overall support and arguments in favor of disabling the submit button.
I agree with #34 that there are 2 separate issues here.
I think that submit should be disabled so that the form canโt be submitted while the ajax change call is running and before the server has responded. If you're going all the way to the server for a change event, it's probably important that it finishes and, if that's the case, the submit button should be disabled until the form is ready to be interacted with again. Since the ajax change call response can modify the values in the form, the user should not be able to submit the form with just the values they provided in the field (e.g., entity reference fields that rely on ajax change events).
However, I donโt think that disabling the submit button addresses the reported issue and, IMO, would unnecessarily expand the scope of this ticket.
The problem described here is that the change event isnโt triggered until the text field loses focus, which can cause data loss because a user can submit the form without losing focus on the field, but before ajax ever runs. In other words, the form gets submitted, but ajax was never triggered, so the value isnโt saved.
I think that further discussion should be around determining what type of event should be used to fire the ajax change.