Added patch with php8 changes where usort expects numbers instead of booleans
- 🇦🇺Australia darvanen Sydney, Australia
Thanks @Hikkypo,
When working with patches it is common practice to provide an interdiff → (required on core issues but this isn't core). It helps reviewers quickly assess changes.
You can also create an MR, apply the previous patch and commit, then commit your update so that it can be seen separately.
Did you happen to address any of the feedback?
Thanks @darvanen i have made an interdiff. I do not believe i had fixed many if any of the feedback you had given ill try to add that now
- 🇧🇷Brazil mabho Rio de Janeiro, RJ
I am using this patch on version 2.1 (it still works there). I have thus changed the version of the module being tested against to
2.x-dev
. I hope this is not a problem. - Merge request !3Apply changes on #3165828 and adjust param type in function comment. → (Open) created by mabho
- 🇧🇷Brazil mabho Rio de Janeiro, RJ
I have just created a merge request for the changes in this thread. I am also uploading a patch file for those who prefer this method.
- First commit to issue fork.