- ๐ฎ๐นItaly plach Venezia
What about using PHP settings to make the behavior configurable? We could make this opt-in by assuming a FALSE default and punt aggregation/filtering to a follow-up issue :)
- ๐จ๐ญSwitzerland berdir Switzerland
I closed ๐ Allow to display/log E_USER_DEPRECATED messages Closed: duplicate as a duplicate. Note that the other issue also tried to handle skipped deprecations, which is IMHO crucial for this, as some of them have been logged a _lot_ historically and would completely spam that log, making it rather useless.
- ๐ฎ๐นItaly plach Venezia
@Berdir
Note that the other issue also tried to handle skipped deprecations, which is IMHO crucial for this, as some of them have been logged a _lot_ historically and would completely spam that log, making it rather useless.
Fair, what about making those configurable via a setting as well? We could hardcode a default if the setting is NULL.
- First commit to issue fork.
- ๐ต๐ฑPoland Graber
Here's some initial work on this: https://git.drupalcode.org/issue/drupal-3024296/-/compare/11.x...3024296...
Not sure if filename - based deprecation level (all, contrib + custom, custom only) filtering is reliable enough, namespace is not for sure as we cannot distinguish contrib from custom at all there. Let's get this moving in any case :) - Status changed to Needs review
10 months ago 11:24am 20 February 2024 - ๐ต๐ฑPoland Graber
Created a MR against 11.x, no tests yet as it'll be nice to receive feedback first and some recommendations what'd be the best way to test (Unit?).
Marking for initial review.
Adding a patch to lock at this state as well to avoid composer issues if the MR gets updated as well. - Status changed to Needs work
10 months ago 2:48pm 20 February 2024 - ๐ต๐ฑPoland Graber
@smutsgrave, yes, I'm aware of that - typo in a comment. Nevertheless, I asked for a small review at this stage to ensure the direction is correct before more hours are spent on this. Can we have it?
- Status changed to Needs review
10 months ago 3:04pm 20 February 2024 - ๐บ๐ธUnited States smustgrave
Go for it. Haven't checked the follow up tag need either.
- Status changed to Needs work
10 months ago 9:07am 21 February 2024 - ๐ต๐ฑPoland Graber
Thanks, received some internal feedback on this and thought about it a bit in the meantime.
TODO:
- fix typo obviously
- remove deprecation level in favor or a boolean switch and ignored file path patterns (*/core/* and */vendor/* by default)
- we should probably only log deprecations instead of displaying them on pages. - Status changed to Needs review
10 months ago 11:34am 21 February 2024 - ๐ต๐ฑPoland Graber
Right, now work has to be done to update existing tests and write new ones. Moving this to review again so we can see if this has chances of merging at this state assuming tests are handled.
- Status changed to Needs work
9 months ago 7:37pm 15 March 2024 - ๐บ๐ธUnited States smustgrave
Seems @alexpott left some feedback on the MR.
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
@alexpott and I have looked at this, removing the tag
- First commit to issue fork.
- ๐ณ๐ฟNew Zealand quietone
Started a test but in the test there is no logging of the deprecation message. I don't see why that is. Anyone?
- ๐ซ๐ทFrance andypost
it may help to catch deprecations from upcoming PHP release ๐ฑ [META] Make Drupal 10.3/11 compatible with PHP 8.4 Active