- Issue created by @GΓ‘bor Hojtsy
- π«π·France andypost
Filed one more child π [PHP 8.4] ReflectionMethod costructor deprecated with one argument Needs review
- π«π·France andypost
- π«π·France andypost
beta updates (via commit 2ad2c6b1c4) fixed https://github.com/php-fig/http-factory/commit/2e735aa9fca24c41454faae25...
- π«π·France andypost
updated vendor patch as
vendor/psr/http-factory/src/UploadedFileFactoryInterface.php
is fixed - π¬π§United Kingdom catch
Tentatively tagging this for 10.3 and 11.0 release highlights. It would be pretty nice to be able to say we're compatible with PHP 8.4 before it's even released, although feels like there might be more breaking changes before it gets to rc, so maybe only really possible for 11.0 rather than 10.3. If there's still outstanding issues or we're not convinced about 8.4 stability, we could change this to 10.4/11.1.
- π«π·France andypost
As release schedule updated PHP feature freeze (13 Aug) and first beta at Aug 15 2024
Added to IS
- π«π·France andypost
ATM the real blocker to pass tests is "prophecy" as usual, all failed tests are caused by not fixed (nullable types) when mocks are instantiated
- π«π·France andypost
btw the commit can be split to new issue https://git.drupalcode.org/project/drupal/-/merge_requests/7783/diffs?co...
- π«π·France andypost
Composer's dependency fixed https://github.com/jsonrainbow/json-schema/releases/tag/5.3.0
- π«π·France andypost
Only 1 failed test left (see #22) https://git.drupalcode.org/issue/drupal-3427903/-/pipelines/226036/test_...
Also there's a lot of deprecations because of prophecy but they could be added to ignored deprecations
- π¬π§United Kingdom catch
That build test failure looks familiar and is something to do with sqlite, π GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled fails on sqlite Needs review shows the same error.
- π«π·France andypost
now all tests passed https://git.drupalcode.org/issue/drupal-3427903/-/pipelines/226076/test_...
the commit needs own issue
- πΊπΈUnited States rfay Palisade, CO, USA
DDEV HEAD has PHP8.4.0alpha2 now, this should help with resolving the various issues. This will be updated and be in the next DDEV release, but is already available easily via HEAD, even using Homebrew. See https://ddev.readthedocs.io/en/stable/developers/building-contributing/#...
- π«π·France andypost
I pushed to CI 8.4alpha3 using patch so in 2 weeks first beta should arive
Ref https://git.drupalcode.org/project/drupalci_environments/-/commit/753d2a...
- π«π·France andypost
PHP released alpha4 instead of broken alpha3
- π«π·France andypost
Guzzle fixed after π Update composer dependencies prior to 11.0.0 Fixed
- πΊπΈUnited States xjm
Moving to target 11.1.0/10.4.0. Some or all of the fixes might still be backportable to the patch branches, but targeting the minors will help us keep track of things as we get closer to the PHP 8.4.0 release.
- π«π·France andypost
Voting for 8.4 deprecations closed
- Deprecate passingE_USER_ERROR
totrigger_error()
- RemoveE_STRICT
error level and deprecateE_STRICT
constant - π«π·France andypost
All tests pass now except
BigPipeTest
π Stop passing E_USER_ERROR to trigger_error() on PHP 8.4 Active1) Drupal\Tests\big_pipe\Functional\BigPipeTest::testBigPipe Two new watchdog entries. Failed asserting that 6 matches expected 4. /builds/issue/drupal-3427903/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php:195
- π«π·France andypost
composer finally released https://getcomposer.org/changelog/2.7.8
production 8.4 image updated so less changes in pipeline
- π«π·France andypost
One more deprecation commited https://wiki.php.net/rfc/deprecate-get-post-sessions
- π«π·France andypost
- π«π·France andypost
New child as backportable to 10.3 π Update mikey179/vfsstream to v1.6.12 for PHP 8.4 Needs review
- π«π·France andypost
Landed π PHP 8.4 session.sid_length and session.sid_bits_per_character are deprecated Active
- π«π·France andypost
PHPstan fixed by pcov added 8.4 image and now only BigPipe test fails
- π«π·France andypost
Commited 2 more
- π PHP 8.4 session.use_only_cookies and session.use_trans_sid are deprecated Active
- [#3470080]one more simple fix π Remove deprecated in PHP 8.4 the \E_STRICT usage Active
- π«π·France andypost
First green run!
The changes in the fix probably needs split π Stop passing E_USER_ERROR to trigger_error() on PHP 8.4 Active