[PHP 8.4] ReflectionMethod constructor deprecated with one argument

Major as the RFC was already fixed for 8.3 compatibility

Seems straight forward.

Should it be tagged 8.4 though?

No, this change was applied since 8.3 but the pointed issue did not check that

Committed and pushed aa2830b3b1 to 11.x and 40898b6120 to 10.3.x. Thanks!

andypost → closed merge request !7839

Reverted this, as PHPStan complains in 10.3.x:

  Line   core/lib/Drupal/Component/Utility/ArgumentsResolver.php  
 ------ --------------------------------------------------------- 
  126    Call to an undefined static method                       
         ReflectionMethod::createFromMethodName().                

Also in 11.x we don't need the PHP_VERSION_ID check, the minimum is PHP 8.3 there.

Better status I guess; it needs to be built for the branch rather than cherry-picked.

Crossposted with the 11.x revert.

Bah - PHPStan should be able to work out the version check... anyhow +1 for the reverts... typically that something that seems simple turns out to not.

Maybe phpstan is not using 8.3 as minimally allowed, otherwise how it possible?

Ref the failed job https://git.drupalcode.org/project/drupal/-/jobs/1481141

https://www.php.net/manual/en/reflectionmethod.createfrommethodname

since 8.3, and the RFC, probably the issue in phpstan but 11.x surely should not have condition

That's a bug https://phpstan.org/r/9aff1e0d-c4d5-4d48-88fb-b0ae0ec482db

reported upstream https://github.com/phpstan/phpstan/issues/10954

added to exclude meantime and it now it needs 10.4.x I bet

Maintainers suggested https://github.com/phpstan/phpstan/issues/10954#issuecomment-2088522792

https://phpstan.org/r/690e2da6-8ad3-4f61-9442-d22971dc836d

$callable = "ReflectionMethod::__construct";

if (method_exists(\ReflectionMethod::class, 'createFromMethodName')) {
    echo "PHP 8.3\n";
    $m = \ReflectionMethod::createFromMethodName($callable);
} else {
    echo "older\n";
    $m = new \ReflectionMethod($callable);
}

Should this be marked fixed?

@smustgrave nope - the messages on the issue about reverts and commits from 11.0.x are the wrong way around.

Committed and pushed 152b7f0694 to 11.x and a6b7ab7388 to 11.0.x. Thanks!

Committed 9c5eeca and pushed to 10.4.x. Thanks!
Committed 6871694 and pushed to 10.3.x. Thanks!

I don't think we should do the suggestion with method exists as this is called a lot - so doing the ignore in PHPStan and the version check in 10.x seems fine.

andypost → closed merge request !7865

andypost → closed merge request !7864

Thank you!

Automatically closed - issue fixed for 2 weeks with no activity.