Remove deprecated in PHP 8.4 the \E_STRICT usage

As per the Stackoverflow discussion

E_ALL will show all level of error, E_STRICT introduced on PHP 5.0 will show suggestion/notice of strict coding standard/best practice. Since PHP 5.4 E_STRICT is been included in E_ALL.

So, a simple replacement of E_STRICT with E_ALL is enough to handle the deprecation.

Reference:
https://stackoverflow.com/questions/32930464/what-is-the-difference-betw...
https://stackoverflow.com/questions/1638238/whats-the-point-of-e-all-e-s...

Nice so only MR needed and update issue summary with proposed changes

Looking back at SF changes, I thing we need to populate E_STRICT in drupal_error_levels() for PHP before 8.4

For the check @andypost mentioned. Sounds like it couldn't hurt to have.

I checked usage of drupal_error_levels() and it is mostly unused, so I think it does not need to add the deprecated and unused type

Added CR → and updated IS, also removed comment as it useless now

Removal didn't break anything so probably doesn't need a deprecation or anything. Looks good.

catch → closed merge request !9090

Had a think about whether the return type of drupal_error_levels() changing needed a CR. Modules do call it, but they only use it for the mapping, not referencing E_STRICT directly at all, so I think it's fine to just remove as 'dead code'.

Committed/pushed to 11.x, thanks!

Maybe we can backport it to 10.4.x?

It was finally commited so expect in RC1

Needs backport

Thank you!

@andypost hope the backport for 10.4.x is done. I verified source code the changes are available in latest pull.

Automatically closed - issue fixed for 2 weeks with no activity.