- Issue created by @andypost
- First commit to issue fork.
- 🇮🇳India arunkumark Coimbatore
As per the Stackoverflow discussion
E_ALL will show all level of error, E_STRICT introduced on PHP 5.0 will show suggestion/notice of strict coding standard/best practice. Since PHP 5.4 E_STRICT is been included in E_ALL.
So, a simple replacement of E_STRICT with E_ALL is enough to handle the deprecation.
Reference:
https://stackoverflow.com/questions/32930464/what-is-the-difference-betw...
https://stackoverflow.com/questions/1638238/whats-the-point-of-e-all-e-s... - 🇫🇷France andypost
Nice so only MR needed and update issue summary with proposed changes
- Merge request !9090Remove deprecated in PHP 8.4 the \E_STRICT usage → (Closed) created by arunkumark
- Status changed to Needs review
about 1 month ago 5:05pm 5 August 2024 - 🇫🇷France andypost
Looking back at SF changes, I thing we need to populate
E_STRICTindrupal_error_levels()for PHP before 8.4 - Status changed to Needs work
20 days ago 12:44pm 27 August 2024 - 🇺🇸United States smustgrave
For the check @andypost mentioned. Sounds like it couldn't hurt to have.
- Status changed to Needs review
17 days ago 12:04am 31 August 2024 - 🇫🇷France andypost
I checked usage of
drupal_error_levels()and it is mostly unused, so I think it does not need to add the deprecated and unused type - Status changed to RTBC
16 days ago 3:46pm 31 August 2024 - 🇺🇸United States smustgrave
Removal didn't break anything so probably doesn't need a deprecation or anything. Looks good.
- Status changed to Fixed
3 days ago 4:01pm 13 September 2024 - 🇬🇧United Kingdom catch
Had a think about whether the return type of drupal_error_levels() changing needed a CR. Modules do call it, but they only use it for the mapping, not referencing E_STRICT directly at all, so I think it's fine to just remove as 'dead code'.
Committed/pushed to 11.x, thanks!
