Fix closures in tests for PHP 8.4

Neat trick for BC.

Reviewing the change and conditions for 8.4 make sense.

Committed 97775e7 and pushed to 11.x. Thanks!

MR doesn't apply to 10.4, moving there for backport.

Re-rolled and adjusted line numbers

MR https://git.drupalcode.org/project/drupal/-/merge_requests/9772

andypost → closed merge request !9658

Seems backport has test failures.

Will keep an eye out

It was pod's scheduling issue so retried EntityReferenceWidgetTest - guess random failure

---- Drupal\Tests\media_library\FunctionalJavascript\EntityReferenceWidgetTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Exception Other      phpunit-16.xml       0 Drupal\Tests\media_library\Function
    PHPUnit Test failed to complete; Error: PHPUnit 9.6.21 by Sebastian
    Bergmann and contributors.
    
    Testing
    Drupal\Tests\media_library\FunctionalJavascript\EntityReferenceWidgetTest
    .E....                                                              6 / 6
    (100%)
    
    Time: 03:29.276, Memory: 8.00 MB
    
    There was 1 error:
    
    1)
    Drupal\Tests\media_library\FunctionalJavascript\EntityReferenceWidgetTest::testWidget
    WebDriver\Exception\ElementClickIntercepted: element click intercepted:
    Element  is not clickable at point (59, 394). Other element would receive
    the click: 
      (Session info: headless chrome=106.0.5249.103)
      (Driver info: chromedriver=106.0.5249.61
    (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux
    5.10.225-213.878.amzn2.x86_64 x86_64)
    
    /builds/issue/drupal-3477366/vendor/lullabot/php-webdriver/lib/WebDriver/Exception.php:198
    /builds/issue/drupal-3477366/vendor/lullabot/php-webdriver/lib/WebDriver/AbstractWebDriver.php:216
    /builds/issue/drupal-3477366/vendor/lullabot/php-webdriver/lib/WebDriver/AbstractWebDriver.php:287
    /builds/issue/drupal-3477366/vendor/lullabot/php-webdriver/lib/WebDriver/Container.php:231
    /builds/issue/drupal-3477366/vendor/lullabot/mink-selenium2-driver/src/Selenium2Driver.php:852
    /builds/issue/drupal-3477366/vendor/lullabot/mink-selenium2-driver/src/Selenium2Driver.php:841
    /builds/issue/drupal-3477366/core/tests/Drupal/FunctionalJavascriptTests/DrupalSelenium2Driver.php:123
    /builds/issue/drupal-3477366/core/tests/Drupal/FunctionalJavascriptTests/DrupalSelenium2Driver.php:210
    /builds/issue/drupal-3477366/core/tests/Drupal/FunctionalJavascriptTests/DrupalSelenium2Driver.php:121
    /builds/issue/drupal-3477366/vendor/behat/mink/src/Element/NodeElement.php:176
    /builds/issue/drupal-3477366/vendor/behat/mink/src/Element/NodeElement.php:186
    /builds/issue/drupal-3477366/vendor/behat/mink/src/Element/TraversableElement.php:119
    /builds/issue/drupal-3477366/core/modules/media_library/tests/src/FunctionalJavascript/MediaLibraryTestBase.php:280
    /builds/issue/drupal-3477366/core/modules/media_library/tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php:221
    /builds/issue/drupal-3477366/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
    
    ERRORS!
    Tests: 6, Assertions: 131, Errors: 1.

Appears all green now

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

some bot's error but rebased

somehow tests fail for 10.4 as branch tests are not green

proper rebase

now it's 10.5/10.4

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

false positive

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

MR opened for 10.5 for bot as patch applicable

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I am not sure the bot looks at the MR base or issue version, maybe it only tries to apply patches to 11.x.

Patch is identical to 11.x version except for the line numbers in error messages.

Committed and pushed 4b3308017f0 to 10.5.x and 7fda601bd78 to 10.4.x. Thanks!

Thank you! only 2 blockers now left!

andypost → closed merge request !10162

andypost → closed merge request !9772

Automatically closed - issue fixed for 2 weeks with no activity.