Fix https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_proprietary_csv_escaping_mechanism

Looks like all arguments should be provided

Closed as duplicate 📌 Fix str_getcsv() usage for PHP 8.4 Active

Seems straight forward enough and caused no failures

Reading https://www.php.net/manual/en/function.fgetcsv.php

Warning
When escape is set to anything other than an empty string ("") it can result in CSV that is not compliant with » RFC 4180 or unable to survive a roundtrip through the PHP CSV functions. The default for escape is "\\" so it is recommended to set it to the empty string explicitly. The default value will change in a future version of PHP, no earlier than PHP 9.0.

I think we need a followup to change our default to an empty string or at least to discuss whether we should change this.

I think we should change the test and demo_umami usages here to the future default as this will not cause issues. We also should file the follow-up for the mailer plugin usages now. FWIW I'm pretty sure that changing escape to '' will be harmless but it seems worth doing in a separate issue.

Thanks Alex! Filed follow-up 📌 Change default escaping of str_getcsv() and fgetcsv() to empty string Active

Applied suggestions for demo and test

Believe feedback for this one has been addressed

I think it backportable to 10.4.x to keep compatibility

Committed and pushed 9cf58fe16c5 to 11.x and 8fc8778c8c5 to 11.1.x and 2e7842f8e51 to 11.0.x and 72b464b48bf to 10.5.x and 35d9969bc56 to 10.4.x and b5c897f4ab1 to 10.3.x. Thanks!

andypost → closed merge request !9649

Automatically closed - issue fixed for 2 weeks with no activity.