- Issue created by @tim-diels
- π§πͺBelgium tim-diels Belgium π§πͺ
Proposed wrong resolution. Changed the text.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:59pm 29 August 2023 - last update
over 1 year ago Composer require failure - π©πͺGermany broon Potsdam
The patch should take of the deprecation. However, on my local dev machine, the tests are skipped.
- π«π·France hdnag
It's still missing the core_version_requirement for the entity_reference_integrity_enforce module to be compatible.
- π§πͺBelgium stijndmd
This needs to be added along with the core_version_requirement for the entity_reference_integrity_enforce module.
This module is flagged compatible with d10 but isn't until this issues if fixed.
- πΊπΈUnited States m.stenta
It's still missing the core_version_requirement for the entity_reference_integrity_enforce module to be compatible.
I committed this directly to the 8.x-1.x branch: https://git.drupalcode.org/project/entity_reference_integrity/-/commit/7...
In reviewing this issue, it looks like we can simply delete the entire
testHookWeightLegacy()
method, since thetestHook()
tests the same thing, using a method that exists.I plan to start a new 2.x branch that drops support for Drupal 9, so we can remove
testHookWeightLegacy()
in that branch and simplify all of this. - πΊπΈUnited States m.stenta
Renaming this issue to specifically focus on removing the deprecated method.
- πΊπΈUnited States m.stenta
Here is the relevant change record which describes the recommended approach: https://www.drupal.org/node/3000490 β
// Getting a list of hook implementors is as simple as making use of the $module variable. $implementors = []; $this->moduleHandler->invokeAllWith($hook, function (callable $hook, string $module) use (&$implementors) { // There is minimal overhead since the hook is not invoked. $implementors[] = $module; });
The purpose of this test is to ensure that
entity_reference_integrity_enforce
's implementation ofhook_entity_predelete()
comes before that of thecomment
module (to confirm that the code inhook_module_implements_alter()
is doing its job).I will refactor the test to make this more clear.
Source: #2831346: hook_entity_predelete is too late to throw an exception β
-
m.stenta β
committed f6012f1a on 2.x
Issue #3380250 by broon, tim-diels, m.stenta: Call to deprecated method...
-
m.stenta β
committed f6012f1a on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.