The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 years ago 11:35am 13 February 2023 - Status changed to Needs work
about 2 years ago 9:11pm 21 February 2023 - 🇺🇸United States smustgrave
This seems like a difficult one to test but from what I can tell it has something to do with parent value.
Tried using the test module provided by the patch. Can it be updated to include parent value as well.
- 🇬🇧United Kingdom AndyF
Tried using the test module provided by the patch. Can it be updated to include parent value as well.
Thanks for your time @smustgrave! I'm not really sure what you're asking for here?
Does it really need work rather than review? I tried my best in the IS, there's a test that fails without the patch, it seems to me like NR is appropriate?
Thanks again!
- 🇫🇮Finland heikkiy Oulu
The patch does not seem to apply anymore against core 10.2.
- Status changed to Needs review
over 1 year ago 9:44pm 26 December 2023 - 🇺🇸United States wells Seattle, WA
Re-roll of #45 attached for Drupal 10.2.x.
- last update
over 1 year ago Custom Commands Failed - Status changed to Needs work
over 1 year ago 7:22pm 27 December 2023 - 🇺🇸United States smustgrave
Recommend turning to an MR for quicker reviews.
#51 seems to have failures.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 3:49am 10 January 2024 - Status changed to Needs work
about 1 year ago 3:55am 10 January 2024 - 🇺🇸United States smustgrave
New functions should use type hints and returns.
Also learned we can use constructor promotion.
- 🇫🇮Finland heikkiy Oulu
I can also confirm that the latest merge request applies against 10.2.
Are there any clear instructions how to repeat the issue without the patch? Would make it easier to test that it works.
I originally applied this patch in our project because we had trouble reordering the fields in the node edit form layout but I also had other related patches applied so I would like to confirm I am testing the right thing.
- 🇺🇸United States jsimonis
heikkiy:
For me, it happens when I am trying to create a set of vertical tabs. So, I create the "tabs" and then the "tab". I drag the tab up under the tabs, then add the content to the tab. Save. The content stays under the tabs item, but the tab has moved down to disabled.
- 🇬🇧United Kingdom malcomio
See 🐛 Nested field groups improperly display as "Disable" in the admin UI Active for details of an issue affecting the field_group module - the core patch seems to fix that for me.
@jsimonis - how are you applying the patch, and what are the failures that you see when trying to apply the patch?
https://vazcell.com/blog/how-apply-patch-drupal-9-and-drupal-10-composer is a good explanation of how to do this.
- 🇺🇸United States loze Los Angeles
I am seeing the same as @malcomio and this patch fixes it for me as well.
Drupal 10.4.2