Yeah, fair enough.
Interesting... thanks for digging this up, @joseph.olstad. I'd still like us to get a test added before we finalize.
Technically the 3.x branch still supports Drupal 9 and doesn't pin itself to Drupal 10.3+. Should we also drop Drupal 9 and raise 10.x min to 10.3?
And should we call 🐛 When " All day" is checked the page will not render. I get a TypeError: get_class(): Argument #1 ($object) must be of type object, null given in get_class (line 268 of modules/contrib/calendar_link/src/Twig/CalendarLinkTwigExtension.php). Active ? Comment #4 over there basically makes this RTBC (before the test and version constraint considerations).
That URL is only presented in a form field to make it easy to copy -- it is not actually a configuration element.
The URL is generated from the callback route and is based on the site by way of the UriHelper::getAbsolute function. From your description it sounds like you Drupal core $base_url value uses http.
Superseded by 🐛 Failed login can still redirect to the "Post login path" Needs review
Looks good to go -- thanks!
Thanks for flagging! I'm not able to take the time to address this at the moment, but would be happy to review and help with a PR.
I think you're right that a toggle would be nice here so we don't have to cut a breaking version.
The Social Auth Google module provides an example of adding additional config in the Social Auth module ecosystem: https://git.drupalcode.org/project/social_auth_google/-/blob/4.0.x/src/F...
Then I think it would just be a matter of evaluating that config when setting the default scopes. I'm not sure if other changes will need to be made, though. https://git.drupalcode.org/project/social_auth_linkedin/-/blob/4.0.x/src...
Added -- thanks for flagging!
Thanks for your work on this, @fjgarlin -- I left a question on the MR that I think will ultimately lead to some additional changes needed. Let me know your thoughts.
@gumdal -- I just re-ran this module's tests and they are all passing for Drupal 9, 10, and 11. The tests are simple, but they do confirm that the module can be installed and it's configuration form can be access.
If you can provide specific environment configurations, reproduction steps and logs, it will be help a lot.
Thanks for the report and the fix!
Agreed -- the performance issue should be separated out.
Thanks for getting the MR started. I have added some CRs there.
Ah, wait, I see -- in my local environment I have a config that is equivalent to:
$settings['memcache']['servers'] = [];
$settings['memcache']['bins'] = [];
But, I did not have that in a remote test environment I was looking at. Hence the confusion. The errors goes away when those settings values are set to empty arrays.
From the discussion it sounds like there is some history to this, but I wonder if there is any way to prevent this error without also requiring that config?
Hmmm same here. I swear this fix worked initially, but now I am seeing the same error as #18 again in 8.x-2.7.
Ack. Good point. This would be difficult to test. Happy merge it someone else is able to do some functional review and get it to RTBC. Otherwise, I'll try to do so eventually. Thanks, @fjgarlin.
Yes, we should include a test for this one.
wells → made their first commit to this issue’s fork.
Thanks, @ankitv18!
wells → changed the visibility of the branch project-update-bot-only to hidden.
wells → changed the visibility of the branch 3256293-throw-an-exception to hidden.
wells → changed the visibility of the branch project-update-bot-only to hidden.
wells → changed the visibility of the branch project-update-bot-only to hidden.
Closing in favor of ✨ Allow to create links with a RRULE (to be recurrent) Active .
Closing in favor of tracking in 🐛 calendar_link() fails silently if date is string but can't be parsed Active .
Adding credits from 📌 Remove watchdog_exception it's deprecated Closed: outdated .
This is addressed by 📌 Automated Drupal 11 compatibility fixes for social_auth_facebook Needs review . Moving credits there.
This looks like an issue with the site's caching mechanism. If you are still experiencing this, please provide steps to reproduce (including other modules and services installed).
Closing this one as outdated and addressing in 💬 Authenticating with an organization email doesn't work Active .
Closing as a duplicate of 💬 Authenticating with an organization email doesn't work Active
wells → changed the visibility of the branch issue/social_auth_microsoft-3159996-3159996-authenticating-with-an to hidden.
wells → changed the visibility of the branch 3159996-authenticating-with-an to hidden.
Focusing this on 4.0.x.
@jonpugh, is this in need of review?
Were you able to get this working?
Looks good. Thanks!
Looks good. Thanks!
Superseded by 📌 Automated Drupal 11 compatibility fixes for social_auth_pbs Needs review
Looks good, thanks!
@thampiajit Social Auth Google had a similar issue over in 🐛 Canceling while granting access results in a critical error Fixed . Could you take a look at that and create a separate issue to address it here?
Keeping this issue focused on getting log in working, we need it to be tested fully and moved to RTBC.
Looks good -- thanks!