Users with duplicate emails being allowed

We have a growing number of users flowing in through social_auth (hundreds of thousands) and the issue of duplicate users has grown since originally reporting the issue.

We observed that the absence of the index cited in #5 🐛 Users with duplicate emails being allowed Active was slowing down the experience overall. Adding the index seems to speed things up substantially.

I suspect that there is still more to do to eliminate the root cause of the originally reported issue, but theoretically, speeding up queries for provider_user_id might help reduce the occurrence of the duplicates. I found that I could still reproduce the issue with the index in play, but it was much harder to replicate.

Any thoughts on this @wells?

bob.hinrichs → made their first commit to this issue’s fork.

There is a new merge request here that introduces using Drupal::lock() to prevent running authenticateUser() in parallel for the same user. We have not yet made this change live, will do so 1/5/24.

I've also sometimes getting duplicate users when user registering with google. Using patch from #8 and will get back tommorrow to see the result

@bob.hinrichs @muaz91 do either of you have follow up from results of monitoring these changes? Does #8 impact the duplication issues? I think that changes in #8 may BC break for implementers, did you also have to make changes to e.g. social_auth_google to use this?

wells → changed the visibility of the branch 4.0.x to hidden.

shaundychko → changed the visibility of the branch 3312958-users-with-duplicate to hidden.

MR 19 should be a different issue since it seeks to address a performance issue rather than this issue of duplicate users.

shaundychko → changed the visibility of the branch 3312958-authentication-locking-prevent-multiple to hidden.

Agreed -- the performance issue should be separated out.

Thanks for getting the MR started. I have added some CRs there.

Sorry I missed the question above (#15). I can report that the locking mechanism in the MR did resolve our duplicate user issue. Thanks much for your attention to this!