calendar_link() fails silently if date is string but can't be parsed

Hi @xurizaemon,
I have fixed this issue calendar_link() fails silently if date is string but can't be parsed and attached patch,
please review and verify.

Fixed missing closing bracket and formatting.

The last submitted patch, 3: calendar-link-fails-silently-if-date-is-string-but-can-t-be-parsed--3.patch, failed testing. View results →

The patch seems to fix the issue

Is there a plan to merge this since it's RTBC?

Sorry for the delay -- two things would really help me move this along:

1. A separate issue to fix existing tests. I haven't had the time to address this directly, an MR would be hugely helpful.
2. Tests added with this issue (essentially a test proving we no longer fail silently for unparsable date strings).

wells → credited leisurman → .

joseph.olstad → made their first commit to this issue’s fork.

Patch 2 removes the closing bracket for the class.

The Patch removes the closing bracket for the class as suggested.

MR patch applies cleanly, unlike patch #2
https://git.drupalcode.org/project/calendar_link/-/merge_requests/11.patch

This patch:

is identical to the MR patch:

https://git.drupalcode.org/project/calendar_link/-/merge_requests/11.patch

Needs work because the href no longer comes out data:text/calendar;

Drupal 10.3.x has busted something somehow or some twig/twig upgrade broke something.
not sure
With that said, patch 17 or MR11 fixes the WSOD problem

I'm still investigating the rest

Still needs work

✨ Views support Fixed

also busted

Ok, some good news, patch #20 works, but only if upgrading to a recent minor release of PHP.

For example, if you are running PHP 8.1.16 with Drupal 10.3, for the calendar_link module to work correctly you must upgrade to PHP 8.1.29 or newer.

If you want to use PHP 8.1.16 successfully in my use case you have to downgrade to Drupal 10.2.

So therefore, I recommend that folks upgrade their minor releases of PHP.

I would imagine it would be similar fix in PHP 8.2 and PHP 8.3, there was some patch release update in PHP that is required by Drupal 10.3+ / Drupal 11+

Interesting... thanks for digging this up, @joseph.olstad. I'd still like us to get a test added before we finalize.

Technically the 3.x branch still supports Drupal 9 and doesn't pin itself to Drupal 10.3+. Should we also drop Drupal 9 and raise 10.x min to 10.3?

And should we call 🐛 When " All day" is checked the page will not render. I get a TypeError: get_class(): Argument #1 ($object) must be of type object, null given in get_class (line 268 of modules/contrib/calendar_link/src/Twig/CalendarLinkTwigExtension.php). Active ? Comment #4 over there basically makes this RTBC (before the test and version constraint considerations).

the mentioned PHP bug doesn't seem to affect previous releases of Drupal core.

For those using Drupal 10.3+ they should upgrade their PHP to the latest patch level. I upgraded mine to 8.1.31
I tested the following php releases:

8.1.31
8.1.29
8.1.26
8.1.22

These above releases all worked correctly with Drupal 10.3.6 with calendar_link 3.0.3 using the above patch and my Add to calendar button produced an .ics file.

8.1.16 did not work correctly, in my case the "Add to calendar" button did not produce an .ics file

In our case our "Add to calendar" button was created with twig in a view using the calendar_link module api.

I just linked two duplicate reported issues, set this issue as their parent.

The duplicate related issues are both fixed by patch #20

🐛 When " All day" is checked the page will not render. I get a TypeError: get_class(): Argument #1 ($object) must be of type object, null given in get_class (line 268 of modules/contrib/calendar_link/src/Twig/CalendarLinkTwigExtension.php). Active

and

🐛 Drupal 10.3.10 seems to break this... Active

This module is currently in an unusable broken state when running Drupal 10.3+ without patch #20

increasing priority since it's a fatal error and unusable without the patch on a currently supported Drupal release.

Yeah, fair enough.

Thank you @wells ! :)