- Merge request !7Issue #3333147: Update README.md file according to "README.md template" → (Merged) created by Sonal Gyanani
- 🇮🇳India kavitha@specbee.com
When trying to apply the patch, the following can be observed:
7.patch:18: trailing whitespace.
# Calendar Link
7.patch:63: trailing whitespace.
library as its foundation. Use composer to install the module
7.patch:73: trailing whitespace.
- Install with composer to ensure dependencies are also installed:
7.patch:79: trailing whitespace.
- Install as you would normally install a contributed Drupal module. For
7.patch:112: trailing whitespace.
Returns an array of links for all available calendar types. Each
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors. - Status changed to Needs review
over 1 year ago 1:39pm 12 June 2023 - last update
over 1 year ago 1 fail - thakurnishant_06 India
Hello Everyone !!
Created a #6 patch for calender link 3.0.x-dev. The patch successfully fix the old README.md according to README.md template.
Can someone please review the patch.Thank you for your support!!!
The last submitted patch, 6: updated #6.patch, failed testing. View results →
- last update
over 1 year ago 1 fail - Assigned to nitin_lama
- Status changed to Needs work
over 1 year ago 6:01am 14 June 2023 - last update
over 1 year ago 1 fail - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:03am 14 June 2023 - 🇮🇳India Nupur Badola
Reviewed MR!7, Patch is not cleanly applied.
a. In ##Use section, `calendar_link` given as twice with same marking as 1. b. Above ## Maintainers, Two lines prior are required.
- Status changed to Needs work
over 1 year ago 2:31pm 8 August 2023 - First commit to issue fork.
- last update
over 1 year ago 1 fail - Status changed to Needs review
over 1 year ago 3:30pm 8 August 2023 - Status changed to Needs work
10 months ago 12:45pm 18 January 2024 - 🇮🇳India Nupur Badola
Reviewed MR!7,
a) 7.diff.txt:151: trailing whitespace. In a twig template file, the following code with generate a link to the event warning: 1 line adds whitespace errors. b) Two line prior to maintainer section is required.
- Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 2:22pm 18 January 2024 - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Status changed to RTBC
10 months ago 8:01am 19 January 2024 - thakurnishant_06 India
Reviewed the MR7 , added some minor update and rest of the changes looks Ok.
Moving to RTBC.
Thanks. - Status changed to Needs work
10 months ago 9:35am 21 January 2024 - 🇮🇳India Nupur Badola
Still the issue exists:
1. Two line prior to "Maintainer" and "Configuration" section is required. - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 4:20pm 21 January 2024 - Status changed to RTBC
10 months ago 7:56am 22 January 2024 - 🇮🇳India Nupur Badola
Reviewed MR!7, the file is updated as per the readme.md file template.
Hence marking it to RTBC. - First commit to issue fork.
- Status changed to Fixed
3 months ago 1:44pm 7 September 2024 -
wells →
committed 8b5e4144 on 3.0.x authored by
Sonal Gyanani →
Issue #3333147 by Sonal Gyanani, avpaderno, thakurnishant_06, nitin_lama...
-
wells →
committed 8b5e4144 on 3.0.x authored by
Sonal Gyanani →