Deprecate/remove jquery.tabbable.shim

📌 Removal :tabbable usage in dialog.js Fixed has a clean MR here, so I think we should try to deprecate this in 10.3.x for removal in 11.0.0 or 12.0.0

📌 Removal :tabbable usage in dialog.js Fixed landed. Could we deprecate in 11.0.0 for removal in 12.0.0 here? We can't deprecate in 10.3 without backporting more of 📌 Removal :tabbable usage in dialog.js Fixed (possible but extra work), or I guess this could wait until 11.1 if we don't want to deprecate new things in 11.0

This is breaking on jQuery 4, which is blocking Drupal 11, bumping to critical. Don't see why we would fix something that's no longer used in 11.x and should have been deprecated years ago. Working on an MR for the library deprecation.

We can do this in 10.3.x without backporting all the JavaScript changes to 10.3.0 if we add the deprecation to deprecation-ignore.txt. Given there has been a valid replacement for this library since Drupal 9.2, I think that might be fine.

+1 on this approach for the reasons described in #20 and #21.

This works for me, 10.3.x deprecation looks good, and 11.x removal is good too.

If we wanted to remove the deprecation skip later, we coudl do 📌 Trigger a JavaScript deprecation error for dialogClass in forked dialog.js Active in 10.3.x by backporting more of 📌 Removal :tabbable usage in dialog.js Fixed , that would in turn allow us to remove the tabbable shim dependency from the dialog library in 10.3.x and then the deprecation wouldn't get triggered. However I think our time is much better spent on 📌 Add a native dialog element to deprecate the jQuery UI dialog Needs work and friends so we don't have to keep forking more and more of jQuery UI to more and more places.

Thanks for the quick reviews here, can't wait to get rid of this!

I think this is the most pragmatic thing to do at this point, seeing as we should have removed this some time ago and we can spend effort better elsewhere.

Committed 7a21759 and pushed to 11.x. Thanks!
Committed b3872f8 and pushed to 10.3.x. Thanks!

quietone → closed merge request !7553

quietone → closed merge request !7552

Something ate @longwave's credit for committing this; fixed now.

credit doesn't happen automatically for commit if you set it fixed before the commits show up on the issue :)

Automatically closed - issue fixed for 2 weeks with no activity.