- Issue created by @smustgrave
- 🇬🇧United Kingdom catch
Re-titling - I figured out the PHP deprecation layer in the other issue, so now this issue is just about whether we want to add a js deprecation too, which seems fine if we can, but also non-critical.
- 🇺🇸United States bnjmnm Ann Arbor, MI
I lost more time than I'd care to admit on a Project Browser issue due to there not being a JS deprecation, so I'm a big +1 on having this done to spare other 10 > 11 upgraders that annoyance.
- First commit to issue fork.
- Status changed to Needs review
3 months ago 6:23am 21 June 2024 - Status changed to RTBC
3 months ago 12:42am 22 June 2024 - 🇺🇸United States smustgrave
Cleaned up issue summary some.
Updated deprecation for 10.4 since 10.3.0 is now out. But deprecation seems fine.
- Status changed to Needs work
3 months ago 12:41pm 22 June 2024 - Status changed to RTBC
3 months ago 3:44pm 22 June 2024 - Status changed to Fixed
3 months ago 7:45pm 22 June 2024 - 🇫🇷France nod_ Lille
Added this issue to the CR: https://www.drupal.org/node/3440844 →
Committed and pushed eeaf9c829e to 11.x and 71230ba40a to 11.0.x and ec9ed86905 to 10.4.x. Thanks!
- Status changed to Needs work
3 months ago 8:40pm 22 June 2024 - 🇫🇷France nod_ Lille
Had to revert on 10.4.x as there are test failures due to the code still using dialogClass somewhere.
- 🇫🇷France nod_ Lille
Remaining self deprecation notices (5) 5x: Javascript Deprecation: dialogClass is deprecated in drupal:10.4.x and will be removed from drupal:12.0.0. 4x in MediaLibraryTest::testAllowedMediaTypes from Drupal\Tests\ckeditor5\FunctionalJavascript 1x in MediaLibraryTest::testAlt from Drupal\Tests\ckeditor5\FunctionalJavascript