After update to Drupal 8.4 VIC replace results instead of appending

Switching to an issue fork workflow.

Since patch "filter-nested-views-2918352-30.patch" doesn't work any more in conjunction with the latest patch of 🐛 Drupal.views.ajaxView is not initializing pagers in nested views Needs work , I manually applied the last RTBC'd patch (filter-nested-views-2918352-19.patch) to this issue's fork, as no other patch after that patch provided an interdiff, it is hard to tell if it introduced any regression.

Alright, fixed the upstream core issue for 11.x! Works great, with the changes from the issue fork. Now we need to backport 🐛 Drupal.views.ajaxView is not initializing pagers in nested views Needs work to 10.1.x, create tests here and create a new SemVer branch, based on the Drupal version 🐛 Drupal.views.ajaxView is not initializing pagers in nested views Needs work gets commited to.

Thanks @Grevil for working on this! The good news is, that it even works without the core patch, which simplifies things a lot. Even with the core patch, it still works, as @Grevil confirmed.

So we only need a test now to prove it works and didn't work before and then we can finally fix this old major issue!

Attaching the current MR state as static patch for composer.

Hiding all patches to proceed in the MR finally.

Interesting, the tests do not run at all under Drupal 10 and fixing the test theme, will make them "properly" fail:

1) Drupal\Tests\views_infinite_scroll\FunctionalJavascript\InfiniteScrollTest::testInfiniteScroll
Failed asserting that 0 matches expected 3.

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:96
/var/www/html/web/modules/custom/views_infinite_scroll/tests/src/FunctionalJavascript/InfiniteScrollTest.php:127
/var/www/html/web/modules/custom/views_infinite_scroll/tests/src/FunctionalJavascript/InfiniteScrollTest.php:62
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

(without the changes from this issue)

I don't get it, "testInfiniteScroll()" inside "tests/src/FunctionalJavascript/InfiniteScrollTest.php" should already fail right now... but it doesn't for some reason...

Here is a patch with only the tests adjusted, but without the changes from this issue (which should fail rn).

My apologies, the test doesn't specifically test views inside views...

That's why the tests succeed.

Ok, @Anybody and I just tested this extensively, and it seems the problem doesn't exist anymore for 2.0.x!

We used the drupal core "glossary" view and changed the pager to use infinity scroll, and everything worked as expected!

These are the pager settings we used:

Pager
Use pager: Infinite Scroll | Click to load, 1 item

More link:
No

After I got on the "/glossary" page and pressed "Load more" a few times, this was the output:

Note, that the duplicate table headers are unrelated (This is a different issue 🐛 Headers in table format repeat on load more instead of adding rows Needs work ).

This might still be an issue related to 8.x-1.x, so I will set the version appropriately and postpone this issue, for people to still see this issue, when running into this again.

The issue does not exist in the latest 2.0.x branch. But it can be committed into 8.x-1.x branch.

@Grevil: See #43 - what should we do here?
I don't think we should touch 8.x-1.x.

Still there are changes in the MR against 2.x?

@Grevil: Without the fixes here, the tests in 2.x are broken... so should we merge this into 2.x or better create a separate issue to fix the tests and close this one as the issue seems to be fixed in 2.x as of #43?

Yes, the issue is fixed and not present anymore in 2.0.x. Drupal 8 is EOL, so we shouldn't make any changes inside 1.x anymore.

Apart from the theme switch, nothing in here is worth committing.

Let's close it.

Ok, should someone encounter the same in 2.x, feel free to reopen with clear steps to reproduce. Thanks!

We used the drupal core "glossary" view and changed the pager to use infinity scroll, and remaining things as expected.

We also tested all formatters with only the pager set. That also worked just fine.