Missing cache tags for page manager pages using default meta tags variant

Open on Drupal.org →

Created on 15 July 2024, 4 months ago

Problem/Motivation

Missing cache tags of Metatag defaults entity for the page manager variants.
The cached page rendered via page manager and using meta tags as `default meta tags` variant is not invalidated on update.

Steps to reproduce

1. Add page manager variant (page).
2. Add `default meta tags` variant for the PM variant.
3. Visit page as anonymous, get the cached page.
4. Update/Translate the meta tags variant.
5. Revisit the page. The page is still cached and not invalidate, shows stale meta.

Proposed resolution

Add cache tags of the metatag_defaults config entity with hook_page_attachments.

🐛 Bug report

Status

Needs review

Version

2.0

Component

Panels integration

Created by

🇬🇪Georgia maximkashuba Batumi

Live updates comments and jobs are added and updated live.

Page Manager

Sign in to follow issues

Merge Requests

!121Missing cache tags for page manager pages using default meta tags variant
Open
🇬🇪Georgia maximkashuba
updated 4 months ago
!120Missing cache tags for page manager pages using default meta tags variant
Open
🇬🇪Georgia maximkashuba
updated 4 months ago

Comments & Activities

Issue created by @maximkashuba
Merge request !120Adds cache dependency of metatag variant for the page manager pages. → (Open) created by maximkashuba
Comment 4 months ago →
🇬🇪Georgia maximkashuba Batumi
Comment 4 months ago →
🇬🇪Georgia maximkashuba Batumi
Status changed to Needs review 4 months ago2:52pm 15 July 2024
Comment 4 months ago →
🇺🇸United States DamienMcKenna NH, USA
Thank you for reporting the bug, and for providing a merge request & patch file.

I'm bumping this to the 2.0.x branch, as that's where all new work goes first.
Comment 4 months ago →
🇺🇸United States DamienMcKenna NH, USA
Can you please create a fresh merge request against 2.0.x? Thank you.
Merge request !121Adds cache dependency of metatag variant for the page manager pages. → (Open) created by maximkashuba
Pipeline finished with Success
4 months ago
Total: 967s
#224795

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024