Drupal 10 upgrade

I've run an analysis with upgrade_status of the plugin.

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Commerce Ticketing 1.0.2
Scanned on Sat, 08/19/2023 - 13:05.

3 errors found. 8 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

web/modules/contrib/commerce_ticketing/modules/commerce_ticketing_pdf/src/Contro
ller/PDFController.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 34   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 54   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_ticketing/src/CommerceTicketListBuilder.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 93   │ Relying on entity queries to check access by default is      │
│ manually │      │ deprecated in drupal:9.2.0 and an error will be thrown from  │
│          │      │ drupal:10.0.0. Call                                          │
│          │      │ \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with │
│          │      │ TRUE or FALSE to specify whether access should be checked.   │
│          │      │                                                              │
│ Check    │ 107  │ Relying on entity queries to check access by default is      │
│ manually │      │ deprecated in drupal:9.2.0 and an error will be thrown from  │
│          │      │ drupal:10.0.0. Call                                          │
│          │      │ \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with │
│          │      │ TRUE or FALSE to specify whether access should be checked.   │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_ticketing/src/Event/TicketEvent.php:
┌──────────┬──────┬───────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                          │
├──────────┼──────┼───────────────────────────────────────────────────────────┤
│ Check    │ 13   │ Class Drupal\commerce_ticketing\Event\TicketEvent extends │
│ manually │      │ deprecated class Symfony\Component\EventDispatcher\Event: │
│          │      │ since Symfony 4.3, use                                    │
│          │      │ "Symfony\Contracts\EventDispatcher\Event" instead         │
│          │      │                                                           │
└──────────┴──────┴───────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_ticketing/src/EventSubscriber/OrderEventSubscriber.
php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 219  │ Relying on entity queries to check access by default is      │
│ manually │      │ deprecated in drupal:9.2.0 and an error will be thrown from  │
│          │      │ drupal:10.0.0. Call                                          │
│          │      │ \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with │
│          │      │ TRUE or FALSE to specify whether access should be checked.   │
│          │      │                                                              │
│ Check    │ 297  │ Relying on entity queries to check access by default is      │
│ manually │      │ deprecated in drupal:9.2.0 and an error will be thrown from  │
│          │      │ drupal:10.0.0. Call                                          │
│          │      │ \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with │
│          │      │ TRUE or FALSE to specify whether access should be checked.   │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_ticketing/src/Form/CommerceTicketForm.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                         MESSAGE                         │
├──────────┼──────┼─────────────────────────────────────────────────────────┤
│ Fix with │ 76   │ Call to deprecated function render(). Deprecated in     │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use     │
│          │      │ Drupal\Core\Render\RendererInterface::render() instead. │
│          │      │                                                         │
└──────────┴──────┴─────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_ticketing/commerce_ticketing.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ manually │      │ compatible with the next major version of Drupal core. See │
│          │      │ https://drupal.org/node/3070687.                           │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_ticketing/modules/commerce_ticketing_pdf/commerce_t
icketing_pdf.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ manually │      │ compatible with the next major version of Drupal core. See │
│          │      │ https://drupal.org/node/3070687.                           │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_ticketing/composer.json:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ The drupal/core requirement is not compatible with the next  │
│ manually │      │ major version of Drupal. Either remove it or update it to be │
│          │      │ compatible. See                                              │
│          │      │ https://drupal.org/node/2514612#s-drupal-9-compatibility.    │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

Reviewed the MR.
Tested the module composer setup through the issue fork on a Drupal 10 installation(10.1.5) and tested the basic functionality. Works fine without any issues.

Did the following steps for testing:

1. Setup a Drupal 10 site through composer.
2. Installed the module using the issue fork by setting the composer repositories.
   

   {
               "type":"vcs",
               "url":"https://git.drupalcode.org/issue/commerce_ticketing-3382034.git"
           }
   

3. composer require "drupal/commerce_ticketing:dev-3382034-drupal-10-upgrade"
4. The module gets installed successfully.
5. Enabled the module and the related Drupal commerce modules. The module gets enabled without any errors.
6. Did the module configurations as per the documentation. Setup the ticket type, product type and product variation using the ticket type. Enabled ticket for order type.
7. Completed the checkout process for ticket type product. The ticket gets generated properly.

@arisen , be care that you don't require the module this way in production drupal, as it is not safe for your site.

Sure @aleix. Just followed this process for testing purpose so i could install the module from the MR using composer instead of using git.
Any suggestion on the safer method to test it? :)

@arisen For test is ok. But for production, as the MR issue repository is public, someone or something could add unwanted code directly to your site when updating with composer.
For production use, better wait for a project release, or if you cannot wait, fork the MR repo branch to your own protected git repo and require from there.

Can confirm that the access check results in an exception

Where can we find this modules for D10 ?
Because it sounds like an interesting module to use in some projects.

Are there any plans on this topic? A short statement from the maintainers would be highly appreciated :) Thank you!

Related on this the entity_print has issues with drupal 10.1 : https://www.drupal.org/project/entity_print/issues/3383187 🐛 Unexpected error with print engine PhpWkhtmlToPdf or DomPdf: Session has not been set Needs review so whenever maintainers release this module, I think it will need to bump the version of Entity Print to latest version with this patch merged.
(I could add as new issue but it's not clear to which version the issue must be attached to)

Thanks for the MR and all the feedback, Unfortunately I don't have the funding anymore to work on this module but I can commit to review patches and merge anything RTBC.

Gracias pedro, Do you think you could review proposed patches or just the ones RTBC? I have it working on production so maybe I could help with main features (in fact I proposed these by now). Namely:

- Theming capabilities.
- Symfony mailer support.
- Fix the sending in some contexts.

As you said somewhere maybe a new release could help. That said maybe someone in this issue could join the efforts to keep this module with a clear future (or claim for help in main commerce module...)

BTW @pcambra i am also aleix in drupal.cat tg group if you want to talk about it.

I'd be happy to, but as I mentioned, I don't have any allocation for this :(
So if the tests pass and someone else's has looked at it to set it RTBC, I can definitely volunteer my time.

Automatically closed - issue fixed for 2 weeks with no activity.