Provide "Date only" widget in form display for date type fields

I discussed with @sorlov a lot regarding this subject, here are several our thoughts:

1. From my personal point of view it was initially wrong idea to combine time and date into field type Date. It would be make sense to have Datetime field type for such cases.

2. Moreover - we have field type called Timestamp. Try to add new field with such field type and find 10 differences from field type Date (in terms of render).

3. If you will inspect form display render of Date type field with Date only field setting enabled - you will see datetime_wrapper with title and form_element. Title is in <h4> tag and this tag is hardcoded in twig template. It points me to the thought that there can be potentially SEO risks. But that's not all -> if we have Date only field setting enabled, why we need datetime-wrapper in that case? The easiest (and obvious) way is to just display label + input. Right now we have datetime-wrapper always applied, no matter if setting Date only enabled or not. Moreover - visually maybe h4 title is looking like a label, but actually it's not. It doesn't have label html tag and it's not clickable (but it should be clickable to get focus on the input element).

Now what we could do with all that. Several proposals:

1. We could rewrite field types and have 3 different field types for different needs: Date (showing date input only, always label + input html tags), Time (for showing input time only + label), Datetime (when we need both, and keep datetime-wrapper for that).

2. We could kick somehow datetime-wrapper wrapper for existing Date field if setting Date only enabled. And show only regular label + input html tags.

3. We could keep everything as it is, but only remove Title from datetime-wrapper and unhide original label html tag (which is hidden right now).

Tried webform → module with Date element as a reference.

This is exactly render i want to have for the Date only field:

Also they are splitting Date and Date/time elements

Several proposals:
....
3. We could keep everything as it is, but only remove Title from datetime-wrapper and unhide original label html tag (which is hidden right now).

This can be done as quick fix on Drupal\Core\Datetime\Element\Datetime to show as Title for Date sub-element instead of rendering title in datetime-wrapper theme template

Attached patch with this solution

The last submitted patch, 7: 3383646-7.patch, failed testing. View results →

Labels for inputs are always present, but can be visually hidden (accessible to screen readers) if the field has multiple cardinality.

There are 2 scenarios: single and multiple cardinality field. For multiple fields the labels are visually hidden by the WidgetBase class, but for fields with a single element, the label is displayed as required by the task.

The Datetime field is flexible and can have 2 variants: date (1 input) or date and time (2 inputs), additionally it has own custom form render element that results in a slightly different rendering order, adds #title_display => 'invisible' property and misses logic of WidgetBase class hiding labels for multiple fields.

So there are options:

1. Single date field/show label
2. Multiple date fields/hide label
3. Single date and time field/hide labels
4. Multiple date and time field/hide labels

An additional example of a multiple simple text field is attached.

Labels for inputs are always present, but can be visually hidden (accessible to screen readers) if the field has multiple cardinality.

There are 2 scenarios: single and multiple cardinality field. For multiple fields the labels are visually hidden by the WidgetBase class, but for fields with a single element, the label is displayed as required by the task.

The Datetime field is flexible and can have 2 variants: date (1 input) or date and time (2 inputs), additionally it has own custom form render element that results in a slightly different rendering order, adds #title_display => 'invisible' property and misses logic of WidgetBase class hiding labels for multiple fields.

So there are states:

1. Single date field/show label
2. Multiple date fields/hide labels
3. Single date and time field/hide label
4. Multiple date and time field/hide labels

An additional example of a multiple simple text field is attached.

The last submitted patch, 11: 3383646-11.patch, failed testing. View results →

Changes in datatime-wrapper template also affect datelist form element and make ElementsLabelsTest::testTitleEscaping() test fail for it

Problem is that if we use date fields on custom form, then they don't have titles with current patch. For testing I've copied FormTestLabelForm into custom module and saw, that only `date` form element has title. That's why test fails.

My solution is to use `form_element` as theme wrapper instead of `datetime_wrapper`, because we need usual label and input HTML structure. In my patch I remove occurencies of `datetime_wrapper`. Failed test runs fine locally after my update. I've also checked all 4 cases from #11 comment on node add form and titles are fine.

If the solution is going to change the issue summary will have to be updated.

Also a CR will probably be needed for other themes to delete their templates.

Oops think I meant to set to NW.

I've been pointed by @sorlov to the issue with duplicating title for date only case, so attaching another patch with the fix for datetime field widget. It adds logic to use title_display setting from the element, if there is no such setting already.
I've updated issue summary, but for the change record, I think, that we need to agree on one of ours solutions first and then add CR if necessary.

Looking at the IS there are 3 solutions, could it be highlighted which approach is being proposed.

Also with template changes will need a CR.

Hi, I've found a couple of related issues which could be considered when fixing this request.

• https://www.drupal.org/project/drupal/issues/2978727 🐛 Use current time setting for the timestamp widget Needs work
• https://www.drupal.org/project/drupal/issues/2978467 →