- First commit to issue fork.
- 🇧🇪Belgium dieterholvoet Brussels
The config schema was in the wrong place, causing it to not be used. I started a MR based on the last patch and fixed this issue there.
- Merge request !4681Issue #2978727: Use current time setting for the timestamp widget → (Open) created by dieterholvoet
- last update
over 1 year ago Custom Commands Failed - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 3:41pm 4 February 2024 - Status changed to Needs work
about 1 year ago 5:48am 5 February 2024 - 🇮🇳India djsagar
Hi @joey91133,
Getting error while applying MR.
moving back to NW.
After MR:
- Status changed to Needs review
about 1 year ago 10:51am 6 February 2024 - 🇹🇼Taiwan joey91133
@djsagar
This is a bug on gitlab.
You should use .diff file not .patch.
I don't know why gitlab will cache patch file on MR. - Status changed to Needs work
about 1 year ago 8:37pm 6 February 2024 - 🇺🇸United States smustgrave
With a schema change going to need an upgrade path + tests around that.
Issue summary will also need to be updated to use standard issue template. With a UI change we probably need a change record.
- 🇬🇧United Kingdom nexusnovaz
Used the 4681 MR to update the patch so it applies on Drupal 10.2.x.
- 🇺🇸United States cantrellnm
#46 doesn't apply for me with Drupal 10.2.7 so here's a re-roll
- 🇧🇪Belgium dieterholvoet Brussels
I rebased the MR against 11.x and fixed an issue where the field value was always overwritten, even if the field already had a value.
- First commit to issue fork.
- 🇳🇱Netherlands Lendude Amsterdam
There was a fatal error when submitting an empty value. Fixed the error and added some test assertions to check this scenario.
- 🇷🇺Russia Chi
I've just released a module that implements the date/time fields in a different way.
It also supports HTML5 elements in views exposed forms
https://www.drupal.org/project/date_point → - First commit to issue fork.
- Merge request !111422978727: Use current time setting for the timestamp widget → (Open) created by man-1982
- First commit to issue fork.
- 🇦🇺Australia geoffreyr
I think I've fixed the TimestampTest by ensuring that
$this->fieldName
gets set. I still see a lot of tests failing but none of them relate to the timestamp widget.BTW hi @man-1982 long time no see (:
- 🇺🇸United States smustgrave
Actually missed one as upgrade path will need test coverage
- 🇦🇺Australia geoffreyr
@smustgrave Thanks for your checks. I've updated the issue description to try and conform to the current template. I don't know much about upgrade path tests but I'll try and figure this out while I'm working on this issue.
I might also see about adjusting the MR and tests further to add functionality. I'd like to ensure we've got an "on demand" setting that lets the field remain empty as long as we need it to.