Account created on 22 September 2010, about 14 years ago
#

Merge Requests

More

Recent comments

πŸ‡¨πŸ‡¦Canada man-1982

Reviewed and tested.
Drupal 10.3
MR was applied without any issue.
Suggest adding MR
thanks

πŸ‡¨πŸ‡¦Canada man-1982

man-1982 β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada man-1982

i can reproduce it only if before i had old configuration from previous version "Swiper formatter"
If you have fresh new version Swiper formatter and a create new teplate profile it can't be reproduce.

Close that ticket as won't be reproduce

thanks

πŸ‡¨πŸ‡¦Canada man-1982

@nk_, @bbu23 Thank you for your work

Close this ticked by know.

We need to focus on testing the new module's features.

πŸ‡¨πŸ‡¦Canada man-1982

It works
Suggest add this functionality to the module

πŸ‡¨πŸ‡¦Canada man-1982

Hi!
New features looks really cool and promises.
going to test lates dev version.
thanks

πŸ‡¨πŸ‡¦Canada man-1982

What's been added:

Drupal modal dialog or native HTML5 dialog option
Controller and route for generating the original Swiper

πŸ‡¨πŸ‡¦Canada man-1982

Hi gays,

i'de like to ask what we decided about patch?
Do we need more extra tests or works?

it would be my pleasure to help with this one.

thanks

πŸ‡¨πŸ‡¦Canada man-1982

As proof of works please consider this gif-video

There is now an option to select another format for the swiper field.

The result of the work is the ability to open a Swiper by clicking on the content teaser, and the swiper will open in a Drupal modal window on the exact slider where the click occurred.

Added cashing base on a tags.

Thank you

πŸ‡¨πŸ‡¦Canada man-1982

Report:
1. I added bad Elasticsearch conf, which doesn work on my local env
2. I had this error

3. Applied patch through composer in composer patches part

"drupal/elasticsearch_connector": {
                "produce fatal error when backend is down": "https://git.drupalcode.org/project/elasticsearch_connector/-/merge_requests/63.patch"
            }

4. Patch was applied without problem, all passed smoothly
5. as a result a can see list of my servers and index

I strongly recommend apply this changes to module.
It seems to me, there is a critical issue, because we don't have access to servers search list without this patch

thanks to
@kallevu
@sokru

πŸ‡¨πŸ‡¦Canada man-1982

Hi @smustgrave!
Could you provide a couple examples or give me direction, where i can have a look and read about

type hints should be included

I didn't clear understand your message.

Thank you.

πŸ‡¨πŸ‡¦Canada man-1982

man-1982 β†’ changed the visibility of the branch 3469036-add-support-for to active.

πŸ‡¨πŸ‡¦Canada man-1982

man-1982 β†’ changed the visibility of the branch 3469036-add-support-for to hidden.

πŸ‡¨πŸ‡¦Canada man-1982

@erik.erskine
Sorry, I double-checked. You are right. There is no need extra router files.
I've made some changes in MR:

  • Added configure route
  • Added some simple functional tests

Thanks

πŸ‡¨πŸ‡¦Canada man-1982

we have daterange_compact.links.menu.yml:

entity.daterange_compact_format.collection:
  title: 'Compact date and time range formats'
  route_name: entity.daterange_compact_format.collection
  description: 'Configure how date and time ranges are displayed in a compact form.'
  parent: system.admin_config_regional
  weight: 0

it's mean that we expect in url /admin/config/regional/daterange-compact-format (=entity.daterange_compact_format.collection) entities list collection
instead we have "Page not found"
I attached a couple screenshot to be more clarified.


πŸ‡¨πŸ‡¦Canada man-1982

Hi everyone,

You do however get a very long scroll bar

@kevinvb you are absolutely right. But in my defenss, i did try a few other approaches (position:static, relative and one more), but this was the only one that actually only worked for me.
@kevinvb i'm alway open for new idea, so if you've got one please let me know. It would be perfect.

@andreastkdf (Andrea Kostakis) special thanks to you, you've put a lot of work. Great job Andrea!

πŸ‡¨πŸ‡¦Canada man-1982

Hi @kevinvb
I've noticed really odd situation. When i tried to apply patch from https://git.drupalcode.org/project/gin/-/merge_requests/459.patch it didn't
work.
However when i applied patch from https://git.drupalcode.org/project/gin/-/merge_requests/459.diff. it were applied without any issue.
I use composer for applying patches.
You can see result on the picture

πŸ‡¨πŸ‡¦Canada man-1982

@kevinvb Hi!

is it possible to provide a patch on the latest release?

It's really interesting and i'm not clear understand how it's work, but i used

"patches": {
            "drupal/gin": {
              "[3242554] Contents of dropdown button go to the left and can be off the visible page": "https://git.drupalcode.org/project/gin/-/merge_requests/459.patch"
            }
        } 

in my composer.json and i can see the patching result in my code. (of course i've deleted gin folder and composer.lock before composer install)
However i see some errors in console during composer install executing, but again i see patch was applied.

[Exception]                                                                                                                                                                   
  Cannot apply patch [3242554] Contents of dropdown button go to the left and can be off the visible page (https://git.drupalcode.org/project/gin/-/merge_requests/459.patch)!                                                                                                                                                          

Also i see Andrea Kostakis (@andreastkdf) added lots of changes in his last commit.

πŸ‡¨πŸ‡¦Canada man-1982

@andreastkdf Hi!
Could you take a loot to your lates commit. I see we can't pass some frontend

πŸ‡¨πŸ‡¦Canada man-1982

Added fixes in css styles and re-worked some JS behaviour.
Ready to review.
Tested on desktop and on mobile too
I've made small movies as a proof, that MR works and can be merge

i used @andreastkdf `s MR and added my changes.
@andreastkdf you've done great work. Thanks

πŸ‡¨πŸ‡¦Canada man-1982

I've prepared some proof that MR does work. I used clean installation Drupal 11.

thanks

πŸ‡¨πŸ‡¦Canada man-1982

Looks like MR ready to review!
Dear Colleagues please you take a look.
Thanks

πŸ‡¨πŸ‡¦Canada man-1982

man-1982 β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada man-1982

man-1982 β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada man-1982

But the actual cookie was with SSESS

I can't force to work my tests
@MykolaVeryha thanks a lots.
You save me.

πŸ‡¨πŸ‡¦Canada man-1982

Looks like fixed
as a proof
you can see small video

πŸ‡¨πŸ‡¦Canada man-1982

@jv24
yep, correct. I used the same approach in my MR.
Looks like all works good
Thanks.

πŸ‡¨πŸ‡¦Canada man-1982

Created Merge Request.
Works good
as a proof attached gif-video

Please review.
Thanks

πŸ‡¨πŸ‡¦Canada man-1982

This patch aims to enhance the daterange_compact module by ensuring that its configuration pages are accessible and function correctly. It also adds a layer of automated testing for future development and maintenance.

Please review the attached patch and provide any feedback or additional testing from the community.

Added daterange_compact.routing.yml and Functional Test DateRangeCompactRoutingTest.php

πŸ‡¨πŸ‡¦Canada man-1982

Hello everyone,
I'm interested in becoming a maintainer for the Formatter Field β†’ project.

Our company has used this module from Drupal 7, and I've contributed by providing patches for issues:
Issue #3406394 πŸ› Formatter Field Not Functioning Correctly in Paragraphs on Drupal 10 Needs review
Issue # 3260320 πŸ› TypeError: Argument 1 passed to Drupal\formatter_field\Plugin\Field\FieldFormatter\FromFieldFormatter::getFormatter() RTBC

I've been working with Drupal for over 13 years, starting from Drupal 6 up to the current Drupal 10.
This experience has given me a strong background in developing and customizing modules for various Drupal versions.

I have several ideas to improve the module:

  • Adde support for third-party display settings.
  • Create a configuration entity for saving settings based on entity type and fields.
  • Develop a migration config/submodule from Drupal 7 to Drupal 10.
  • Implement and follow security best practices.

I am also ready to take on the responsibilities that come with security coverage.
I believe my technical skills and my dedication to the Drupal community make me a good fit for maintaining this module..

Thank you for considering my application.

Best,
Andrii Kocherhin β†’

πŸ‡¨πŸ‡¦Canada man-1982

Hi everyone
I've created patch which can fix this issue.
you can see it here
https://www.drupal.org/project/formatter_field/issues/3406394 πŸ› Formatter Field Not Functioning Correctly in Paragraphs on Drupal 10 Needs review
Thanks

πŸ‡¨πŸ‡¦Canada man-1982

I noticed an issue: when attempting to edit or add a field in the "Manage fields" section, I consistently encountered an error. The error message displayed was:

The website encountered an unexpected error. Please try again later.

TypeError: array_intersect_key(): Argument #1 ($array) must be of type array, bool given in array_intersect_key() (line 158 of core/lib/Drupal/Core/Field/FormatterPluginManager.php).

To resolve this issue, I applied a patch which successfully addressed the problem.

My patch extends the patch by @validoll.
Thanks

πŸ‡¨πŸ‡¦Canada man-1982

Test Environment:

Drupal version: 10.1.6
DB driver: MySQL
PHP OS: Linux
PHP version: 8.1.25

Results:

The patch successfully resolved the issue described. All works good.
Suggested @JurriaanRoelofs to add patch to main branch.
thanks

πŸ‡¨πŸ‡¦Canada man-1982

The patch in #17 functions as expected. It was tested with the following configurations:

Drupal version: 10.1.6
PHP version: 8.1.25
Additionally, the latest development version of the module was used: composer require 'drupal/focal_point:2.x-dev@dev'.

Suggest to add this patch into main branch.

Thank you.

πŸ‡¨πŸ‡¦Canada man-1982

All works good!
The "Entity embed" dev with this patch( https://www.drupal.org/project/entity_embed/issues/3272732 ✨ Drupal 10 & CKEditor 5 readiness Fixed ) can't work without this patch.
Please merge its.

Production build 0.71.5 2024